]> source.dussan.org Git - jquery.git/commitdiff
Build: Make the import/no-unused-modules ESLint rule work in WebStorm
authorMichał Gołębiowski-Owczarek <m.goleb@gmail.com>
Wed, 2 Sep 2020 15:24:55 +0000 (17:24 +0200)
committerGitHub <noreply@github.com>
Wed, 2 Sep 2020 15:24:55 +0000 (17:24 +0200)
When run via WebStorm, the root path against which paths in the config of the
`import/no-unused-modules` ESLint rule are resolved is the path where the ESLint
config file that defines the rule lies, i.e. `src`. When run via the command
line, it's usually the root folder of the jQuery repository. This pattern
intends to catch both.

Note that we cannot specify two patterns here:
```js
[ "src/*.js", "*.js" ]
```
as they're analyzed individually and the rule crashes if a pattern cannot be
matched.

Closes gh-4777

src/.eslintrc.json

index 96b83ff1098c5e6533145bf0abe21a9602cdd993..f1b596dff1b075e925c45659b16914fa306d8d85 100644 (file)
                "import/no-cycle": "error",
                "import/no-unused-modules": [ "error", {
                        "unusedExports": true,
-                       "ignoreExports": [ "src/*.js" ]
+
+                       // When run via WebStorm, the root path against which these paths
+                       // are resolved is the path where this ESLint config file lies,
+                       // i.e. `src`. When run via the command line, it's usually the root
+                       // folder of the jQuery repository. This pattern intends to catch both.
+                       // Note that we cannot specify two patterns here:
+                       //     [ "src/*.js", "*.js" ]
+                       // as they're analyzed individually and the rule crashes if a pattern
+                       // cannot be matched.
+                       "ignoreExports": [ "{src/,}*.js" ]
                } ],
                "indent": [ "error", "tab", {
                        "outerIIFEBody": 0