Don't skip condition if defined (#15880).

git-svn-id: http://svn.redmine.org/redmine/trunk@15507 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/lib/redmine/menu_manager.rb b/lib/redmine/menu_manager.rb
index 0d2d19a43ff27845b7ed20ba709bc43fa2bc1b28..3d19edce7f4542a093b1b741384b3e3b8fdb1a6d 100644 (file)
--- a/lib/redmine/menu_manager.rb
+++ b/lib/redmine/menu_manager.rb
@@ -446,8 +446,7 @@ module Redmine
           # it is considered an allowed node if at least one of the children is allowed
           all_children = children
           all_children += child_menus.call(project) if child_menus
-          return true if all_children.detect{|child| child.allowed?(user, project) }
-          return false
+          return false unless all_children.detect{|child| child.allowed?(user, project) }
         elsif user && project
           if permission
             unless user.allowed_to?(permission, project)