]> source.dussan.org Git - jquery-ui.git/commitdiff
Button: Remove obsolete mouse click coordinates checking. Fixed #7665 - Button: Radio...
authorFabrício Matté <ult_combo@hotmail.com>
Sun, 27 Oct 2013 02:33:25 +0000 (00:33 -0200)
committerScott González <scott.gonzalez@gmail.com>
Tue, 29 Oct 2013 16:51:17 +0000 (12:51 -0400)
ui/jquery.ui.button.js

index ae3b86ae9d4b3ec8458a35fee3b44cecb5366d81..6bde7863fd8d2636ff0d289e210798692451ea7b 100644 (file)
@@ -14,7 +14,7 @@
  */
 (function( $, undefined ) {
 
-var lastActive, startXPos, startYPos, clickDragged,
+var lastActive,
        baseClasses = "ui-button ui-widget ui-state-default ui-corner-all",
        typeClasses = "ui-button-icons-only ui-button-icon-only ui-button-text-icons ui-button-text-icon-primary ui-button-text-icon-secondary ui-button-text-only",
        formResetHandler = function() {
@@ -115,42 +115,19 @@ $.widget( "ui.button", {
 
                if ( toggleButton ) {
                        this.element.bind( "change" + this.eventNamespace, function() {
-                               if ( clickDragged ) {
-                                       return;
-                               }
                                that.refresh();
                        });
-                       // if mouse moves between mousedown and mouseup (drag) set clickDragged flag
-                       // prevents issue where button state changes but checkbox/radio checked state
-                       // does not in Firefox (see ticket #6970)
-                       this.buttonElement
-                               .bind( "mousedown" + this.eventNamespace, function( event ) {
-                                       if ( options.disabled ) {
-                                               return;
-                                       }
-                                       clickDragged = false;
-                                       startXPos = event.pageX;
-                                       startYPos = event.pageY;
-                               })
-                               .bind( "mouseup" + this.eventNamespace, function( event ) {
-                                       if ( options.disabled ) {
-                                               return;
-                                       }
-                                       if ( startXPos !== event.pageX || startYPos !== event.pageY ) {
-                                               clickDragged = true;
-                                       }
-                       });
                }
 
                if ( this.type === "checkbox" ) {
                        this.buttonElement.bind( "click" + this.eventNamespace, function() {
-                               if ( options.disabled || clickDragged ) {
+                               if ( options.disabled ) {
                                        return false;
                                }
                        });
                } else if ( this.type === "radio" ) {
                        this.buttonElement.bind( "click" + this.eventNamespace, function() {
-                               if ( options.disabled || clickDragged ) {
+                               if ( options.disabled ) {
                                        return false;
                                }
                                $( this ).addClass( "ui-state-active" );