[Share 2.0] Remove setId and setProviderId from the interface

Those should only ever be set by the providers

diff --git a/lib/private/share20/manager.php b/lib/private/share20/manager.php
index 52580e27818fc898cef68f6a039ea94575102c3a..d6245f4beac27907dfb4d7065df7a84901f2a794 100644 (file)
--- a/lib/private/share20/manager.php
+++ b/lib/private/share20/manager.php
@@ -497,7 +497,6 @@ class Manager implements IManager {
 
                $provider = $this->factory->getProviderForType($share->getShareType());
                $share = $provider->create($share);
-               $share->setProviderId($provider->identifier());
 
                // Post share hook
                $postHookData = [
@@ -754,7 +753,6 @@ class Manager implements IManager {
                $provider = $this->factory->getProvider($providerId);
 
                $share = $provider->getShareById($id);
-               $share->setProviderId($provider->identifier());
 
                return $share;
        }

diff --git a/lib/public/share/ishare.php b/lib/public/share/ishare.php
index 2fb41a17add20041dae46b81bb2d45ecbd93d0ac..80e7f7f56efe1669bee0266e4dcb09c987b8ba29 100644 (file)
--- a/lib/public/share/ishare.php
+++ b/lib/public/share/ishare.php
@@ -43,15 +43,6 @@ interface IShare {
         */
        public function getId();
 
-       /**
-        * Set the internal id of the share.
-        *
-        * @param string $id
-        * @return \OCP\Share\IShare The modified share object
-        * @since 9.0.0
-        */
-       public function setId($id);
-
        /**
         * Get the full share id. This is the <providerid>:<internalid>.
         * The full id is unique in the system.
@@ -61,15 +52,6 @@ interface IShare {
         */
        public function getFullId();
 
-       /**
-        * Set the provider id
-        *
-        * @param string $id
-        * @return \OCP\Share\IShare The modified share object\
-        * @since 9.0.0
-        */
-       public function setProviderId($id);
-
        /**
         * Set the node of the file/folder that is shared
         *