code cleanup: rubocop: fix Style/RedundantConditional in app/helpers/issues_helper.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18502 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 411da95ab6bd81c88259368b0691befb809a4ef1..4c3334f2ed3c1553d02cc19709127b86c88e4042 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1504,7 +1504,6 @@ Style/RedundantConditional:
   Exclude:
     - 'app/controllers/workflows_controller.rb'
     - 'app/helpers/application_helper.rb'
-    - 'app/helpers/issues_helper.rb'
     - 'app/models/enumeration.rb'
     - 'lib/redmine/field_format.rb'
 

diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index 45ce59a52a324324e16b23aa29f29672218c680f..10c179550f1d64b68832782ab7afaa5d6539f0c0 100644 (file)
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -370,7 +370,7 @@ module IssuesHelper
   # Returns the textual representation of a journal details
   # as an array of strings
   def details_to_strings(details, no_html=false, options={})
-    options[:only_path] = (options[:only_path] == false ? false : true)
+    options[:only_path] = !(options[:only_path] == false)
     strings = []
     values_by_field = {}
     details.each do |detail|