Fix quality flaws

diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/BulkChange.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/BulkChange.java
index d20dd2203154df46867a72f1a20f8aa3ed6dd94a..020715111f756097840e1f757aec525f6b497ef7 100644 (file)
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/BulkChange.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/BulkChange.java
@@ -28,8 +28,8 @@ public interface BulkChange {
 
   List<String> issuesNotChangedKeys();
 
-  int totalIssuesChanged();
+  Integer totalIssuesChanged();
 
-  int totalIssuesNotChanged();
+  Integer totalIssuesNotChanged();
 
 }

diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/internal/DefaultBulkChange.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/internal/DefaultBulkChange.java
index de76f8a54bd2ce972ba7126ba4baa404161b7d7f..fe44ebe63d114d36daecc0f5c72cc4f9d58a8878 100644 (file)
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/internal/DefaultBulkChange.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/internal/DefaultBulkChange.java
@@ -21,6 +21,7 @@ package org.sonar.wsclient.issue.internal;
 
 import org.sonar.wsclient.issue.BulkChange;
 
+import javax.annotation.CheckForNull;
 import javax.annotation.Nullable;
 
 import java.util.ArrayList;
@@ -31,28 +32,30 @@ import java.util.List;
  */
 public class DefaultBulkChange implements BulkChange {
 
-  private int totalIssuesChanged;
-  private int totalIssuesNotChanged;
+  private Integer totalIssuesChanged;
+  private Integer totalIssuesNotChanged;
   private final List<String> issuesNotChangedKeys = new ArrayList<String>();
 
   public List<String> issuesNotChangedKeys() {
     return issuesNotChangedKeys;
   }
 
-  public int totalIssuesChanged() {
+  @CheckForNull
+  public Integer totalIssuesChanged() {
     return totalIssuesChanged;
   }
 
-  public int totalIssuesNotChanged() {
+  @CheckForNull
+  public Integer totalIssuesNotChanged() {
     return totalIssuesNotChanged;
   }
 
-  DefaultBulkChange setTotalIssuesChanged(@Nullable int totalIssuesChanged) {
+  DefaultBulkChange setTotalIssuesChanged(@Nullable Integer totalIssuesChanged) {
     this.totalIssuesChanged = totalIssuesChanged;
     return this;
   }
 
-  DefaultBulkChange setTotalIssuesNotChanged(@Nullable int totalIssuesNotChanged) {
+  DefaultBulkChange setTotalIssuesNotChanged(@Nullable Integer totalIssuesNotChanged) {
     this.totalIssuesNotChanged = totalIssuesNotChanged;
     return this;
   }

diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/services/Authentication.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/services/Authentication.java
index 9c669f8fd29f3a0abef0007c719e11f76b76c745..5bf6b0623775cbd8194b30610f9896925589e651 100644 (file)
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/services/Authentication.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/services/Authentication.java
@@ -19,16 +19,15 @@
  */
 package org.sonar.wsclient.services;
 
-import javax.annotation.Nullable;
-
 public class Authentication extends Model {
+
   private boolean valid;
 
-  public boolean isValid() {
+   public boolean isValid() {
     return valid;
   }
 
-  public Authentication setValid(@Nullable boolean valid) {
+  public Authentication setValid(boolean valid) {
     this.valid = valid;
     return this;
   }

diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/services/Profile.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/services/Profile.java
index d709e970e7869ec1efa89e8df92d016d1a535fcc..75b335fd11663424a610e3418f575d08e3865d24 100644 (file)
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/services/Profile.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/services/Profile.java
@@ -60,7 +60,7 @@ public class Profile extends Model {
     return defaultProfile;
   }
 
-  public Profile setDefaultProfile(@Nullable boolean b) {
+  public Profile setDefaultProfile(boolean b) {
     this.defaultProfile = b;
     return this;
   }

diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/services/ResourceSearchResult.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/services/ResourceSearchResult.java
index 83abf7f37bbe56cec50d8ec179c0431bb3c84de5..bc3927deb56ace4f29f72f43925b7c73d6c09f1a 100644 (file)
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/services/ResourceSearchResult.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/services/ResourceSearchResult.java
@@ -58,14 +58,16 @@ public class ResourceSearchResult extends Model {
   }
 
 
-  private int page, pageSize, total;
+  private Integer page, pageSize, total;
   private List<ResourceSearchResult.Resource> resources;
 
-  public int getPage() {
+  @CheckForNull
+  public Integer getPage() {
     return page;
   }
 
-  public int getTotal() {
+  @CheckForNull
+  public Integer getTotal() {
     return total;
   }
 
@@ -73,19 +75,20 @@ public class ResourceSearchResult extends Model {
     return resources;
   }
 
-  public void setPage(@Nullable int page) {
+  public void setPage(@Nullable Integer page) {
     this.page = page;
   }
 
-  public void setTotal(@Nullable int total) {
+  public void setTotal(@Nullable Integer total) {
     this.total = total;
   }
 
-  public int getPageSize() {
+  @CheckForNull
+  public Integer getPageSize() {
     return pageSize;
   }
 
-  public void setPageSize(@Nullable int pageSize) {
+  public void setPageSize(@Nullable Integer pageSize) {
     this.pageSize = pageSize;
   }
 

diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/unmarshallers/AuthenticationUnmarshaller.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/unmarshallers/AuthenticationUnmarshaller.java
index 471a0853d4d39f2be2e05e98f60400b3be26f273..650c20fee48ddd5f68dc9746690f38fb9e9f51a4 100644 (file)
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/unmarshallers/AuthenticationUnmarshaller.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/unmarshallers/AuthenticationUnmarshaller.java
@@ -25,12 +25,13 @@ import org.sonar.wsclient.services.WSUtils;
 import java.util.List;
 
 public class AuthenticationUnmarshaller implements Unmarshaller<Authentication> {
+
   public Authentication toModel(String json) {
     WSUtils utils = WSUtils.getINSTANCE();
     Object map = utils.parse(json);
 
-    return new Authentication()
-        .setValid(utils.getBoolean(map, "valid"));
+    Boolean validJson = utils.getBoolean(map, "valid");
+    return new Authentication().setValid(validJson != null ? validJson : false);
   }
 
   public List<Authentication> toModels(String json) {

diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/unmarshallers/ProfileUnmarshaller.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/unmarshallers/ProfileUnmarshaller.java
index ab200984d8a494738cd91b78289a6f168987c672..1f28afaf1b75a13e79e82fb9ed5500776f318524 100644 (file)
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/unmarshallers/ProfileUnmarshaller.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/unmarshallers/ProfileUnmarshaller.java
@@ -28,10 +28,11 @@ public class ProfileUnmarshaller extends AbstractUnmarshaller<Profile> {
   protected Profile parse(Object json) {
     WSUtils utils = WSUtils.getINSTANCE();
     Profile profile = new Profile();
+    Boolean defaultProfile = utils.getBoolean(json, "default");
     profile
         .setLanguage(utils.getString(json, "language"))
         .setName(utils.getString(json, "name"))
-        .setDefaultProfile(utils.getBoolean(json, "default"))
+        .setDefaultProfile(defaultProfile != null ? defaultProfile : false)
         .setParentName(utils.getString(json, "parent"));
 
     parseRules(utils, profile, json);

diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/unmarshallers/ResourceSearchUnmarshaller.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/unmarshallers/ResourceSearchUnmarshaller.java
index 011aa893d22e5062124ae0c727d29179460b60f9..407bfdecace391f9840e9f9cb11ddbf627698bf2 100644 (file)
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/unmarshallers/ResourceSearchUnmarshaller.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/unmarshallers/ResourceSearchUnmarshaller.java
@@ -19,6 +19,7 @@
  */
 package org.sonar.wsclient.unmarshallers;
 
+import org.json.simple.JSONArray;
 import org.json.simple.JSONObject;
 import org.sonar.wsclient.services.ResourceSearchResult;
 import org.sonar.wsclient.services.WSUtils;
@@ -40,12 +41,15 @@ public class ResourceSearchUnmarshaller extends AbstractUnmarshaller<ResourceSea
     result.setTotal(utils.getInteger(json, "total"));
 
     List<ResourceSearchResult.Resource> resources = new ArrayList<ResourceSearchResult.Resource>();
-    for (Object jsonResource : JsonUtils.getArray((JSONObject) json, "data")) {
-      ResourceSearchResult.Resource resource = new ResourceSearchResult.Resource();
-      resource.setKey(JsonUtils.getString((JSONObject) jsonResource, "key"));
-      resource.setName(JsonUtils.getString((JSONObject) jsonResource, "nm"));
-      resource.setQualifier(JsonUtils.getString((JSONObject) jsonResource, "q"));
-      resources.add(resource);
+    JSONArray dataJson = JsonUtils.getArray((JSONObject) json, "data");
+    if (dataJson != null) {
+      for (Object jsonResource : dataJson) {
+        ResourceSearchResult.Resource resource = new ResourceSearchResult.Resource();
+        resource.setKey(JsonUtils.getString((JSONObject) jsonResource, "key"));
+        resource.setName(JsonUtils.getString((JSONObject) jsonResource, "nm"));
+        resource.setQualifier(JsonUtils.getString((JSONObject) jsonResource, "q"));
+        resources.add(resource);
+      }
     }
     result.setResources(resources);
     return result;

diff --git a/sonar-ws-client/src/test/java/org/sonar/wsclient/services/AuthenticationTest.java b/sonar-ws-client/src/test/java/org/sonar/wsclient/services/AuthenticationTest.java
index 193dd56ed5514cf0fbd329d0c624e00ef0d216e6..684177a176c413103852b989520be3cf89e9125b 100644 (file)
--- a/sonar-ws-client/src/test/java/org/sonar/wsclient/services/AuthenticationTest.java
+++ b/sonar-ws-client/src/test/java/org/sonar/wsclient/services/AuthenticationTest.java
@@ -24,6 +24,7 @@ import org.junit.Test;
 import static org.fest.assertions.Assertions.assertThat;
 
 public class AuthenticationTest {
+
   @Test
   public void should_set_valid_state() {
     assertThat(new Authentication().isValid()).isFalse();