Fix some quality flaws

diff --git a/sonar-batch/src/main/java/org/sonar/batch/DefaultSensorContext.java b/sonar-batch/src/main/java/org/sonar/batch/DefaultSensorContext.java
index 5dcda3d333271b8b033ce5c73ceff0cbdbe604e1..253ca73c2b2afa8d2c2ae98ccb5c81bb676b471e 100644 (file)
--- a/sonar-batch/src/main/java/org/sonar/batch/DefaultSensorContext.java
+++ b/sonar-batch/src/main/java/org/sonar/batch/DefaultSensorContext.java
@@ -155,7 +155,7 @@ public class DefaultSensorContext implements SensorContext {
     return index.getOutgoingEdges(resourceOrProject(from));
   }
 
-  public void saveSource(Resource reference, String source) throws DuplicatedSourceException {
+  public void saveSource(Resource reference, String source) {
     index.setSource(reference, source);
   }
 

diff --git a/sonar-batch/src/main/java/org/sonar/batch/index/DefaultResourcePersister.java b/sonar-batch/src/main/java/org/sonar/batch/index/DefaultResourcePersister.java
index 57037c987fd2c2c4c67128ef835b14a533fd7540..c9058d855bdc8ad9f08253df0a33326006efbfda 100644 (file)
--- a/sonar-batch/src/main/java/org/sonar/batch/index/DefaultResourcePersister.java
+++ b/sonar-batch/src/main/java/org/sonar/batch/index/DefaultResourcePersister.java
@@ -87,7 +87,7 @@ public final class DefaultResourcePersister implements ResourcePersister {
     return snapshotsByResource.get(reference);
   }
 
-  public Snapshot getSnapshotOrFail(Resource resource) throws ResourceNotPersistedException {
+  public Snapshot getSnapshotOrFail(Resource resource) {
     Snapshot snapshot = getSnapshot(resource);
     if (snapshot == null) {
       throw new ResourceNotPersistedException(resource);

diff --git a/sonar-core/src/main/java/org/sonar/core/persistence/DatabaseMigrator.java b/sonar-core/src/main/java/org/sonar/core/persistence/DatabaseMigrator.java
index 889bcd2014f59fbeaa36bd271b2550d325912c05..3e6e562386283e1031ecc3b3c1a650efe6600535 100644 (file)
--- a/sonar-core/src/main/java/org/sonar/core/persistence/DatabaseMigrator.java
+++ b/sonar-core/src/main/java/org/sonar/core/persistence/DatabaseMigrator.java
@@ -51,7 +51,15 @@ public class DatabaseMigrator implements ServerComponent {
       try {
         DdlUtils.createSchema(connection, database.getDialect().getId());
       } finally {
-        session.close();
+        try {
+          session.close();
+
+          // The connection is probably already closed by session.close()
+          // but it's not documented in mybatis javadoc.
+          connection.close();
+        } catch (Exception e) {
+          // ignore
+        }
       }
       return true;
     }

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/database/model/MeasureModel.java b/sonar-plugin-api/src/main/java/org/sonar/api/database/model/MeasureModel.java
index c0a56de9dd36e353706ee274d609f2c7d048b956..3c3a94bd4b965c6a9930d03062cb587eb509db80 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/database/model/MeasureModel.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/database/model/MeasureModel.java
@@ -184,7 +184,7 @@ public class MeasureModel implements Cloneable {
    *
    * @throws IllegalArgumentException in case value is not a valid double
    */
-  public MeasureModel setValue(Double value) throws IllegalArgumentException {
+  public MeasureModel setValue(Double value) {
     if (value != null && (value.isNaN() || value.isInfinite())) {
       throw new IllegalArgumentException();
     }