cancel sharing if some users doesn't have a working encryption set-up.

diff --git a/apps/files_encryption/hooks/hooks.php b/apps/files_encryption/hooks/hooks.php
index b2a17f6bca5e344646a76a8e42354d765f439ed4..be95037784e676909189c6f87adc43cccc0c7a0e 100644 (file)
--- a/apps/files_encryption/hooks/hooks.php
+++ b/apps/files_encryption/hooks/hooks.php
@@ -250,21 +250,18 @@ class Hooks {
                                break;\r
                }\r
 \r
-               $error = false;\r
+               $notConfigured = array();\r
                foreach ($users as $user) {\r
                        if (!$view->file_exists($user . '.public.key')) {\r
-                               $error = true;\r
-                               break;\r
+                               $notConfigured[] = $user;\r
                        }\r
                }\r
 \r
-               if ($error) // Set flag var 'run' to notify emitting\r
-                       // script that hook execution failed\r
-               {\r
-                       $params['run']->run = false;\r
+               if (count($notConfigured) > 0) {\r
+                       $params['run'] = false;\r
+                       $params['error'] = 'Following users are not set up for encryption: ' . join(', ' , $notConfigured);\r
                }\r
-               // TODO: Make sure files_sharing provides user\r
-               // feedback on failed share\r
+               \r
        }\r
 \r
        /**\r

diff --git a/lib/public/share.php b/lib/public/share.php
index b349dd48776b6fe885e30d119837e13c7c9f739c..63645e6fa34bd15bb2f8ec493ecda0531d6b8fc5 100644 (file)
--- a/lib/public/share.php
+++ b/lib/public/share.php
@@ -1288,6 +1288,8 @@ class Share {
                if ($shareType == self::SHARE_TYPE_GROUP) {
                        $groupItemTarget = self::generateTarget($itemType, $itemSource, $shareType, $shareWith['group'],
                                $uidOwner, $suggestedItemTarget);
+                       $run = true;
+                       $error = '';
                        \OC_Hook::emit('OCP\Share', 'pre_shared', array(
                                'itemType' => $itemType,
                                'itemSource' => $itemSource,
@@ -1297,8 +1299,15 @@ class Share {
                                'uidOwner' => $uidOwner,
                                'permissions' => $permissions,
                                'fileSource' => $fileSource,
-                               'token' => $token
+                               'token' => $token,
+                               'run' => &$run,
+                               'error' => &$error
                        ));
+                       
+                       if ($run === false) {
+                               throw new \Exception($error);
+                       }
+                       
                        if (isset($fileSource)) {
                                if ($parentFolder) {
                                        if ($parentFolder === true) {
@@ -1374,6 +1383,8 @@ class Share {
                } else {
                        $itemTarget = self::generateTarget($itemType, $itemSource, $shareType, $shareWith, $uidOwner,
                                $suggestedItemTarget);
+                       $run = true;
+                       $error = '';
                        \OC_Hook::emit('OCP\Share', 'pre_shared', array(
                                'itemType' => $itemType,
                                'itemSource' => $itemSource,
@@ -1383,8 +1394,15 @@ class Share {
                                'uidOwner' => $uidOwner,
                                'permissions' => $permissions,
                                'fileSource' => $fileSource,
-                               'token' => $token
+                               'token' => $token,
+                               'run' => &$run,
+                               'error' => &$error
                        ));
+                       
+                       if ($run === false) {
+                               throw new \Exception($error);
+                       }
+                       
                        if (isset($fileSource)) {
                                if ($parentFolder) {
                                        if ($parentFolder === true) {