]> source.dussan.org Git - nextcloud-server.git/commitdiff
SCSSCacher - Lock should not be removed 23488/head
authorMorris Jobke <hey@morrisjobke.de>
Thu, 15 Oct 2020 21:48:26 +0000 (23:48 +0200)
committerMorris Jobke <hey@morrisjobke.de>
Fri, 16 Oct 2020 08:02:18 +0000 (10:02 +0200)
This is within the failed lock acquiring branch. So the lock is free by another process and should not be removed because the cached file (that was created by the process having the lock) appeared on the filesystem.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
lib/private/Template/SCSSCacher.php

index 08400fd8c7243b3751813ad2af3a4fde1170f7cd..d2c04a4a85a8ada0b678c9f750727476f1d5c46d 100644 (file)
@@ -169,7 +169,6 @@ class SCSSCacher {
                                $this->logger->debug('SCSSCacher::process check in while loop follows', ['app' => 'scss_cacher']);
                                if (!$this->variablesChanged() && $this->isCached($fileNameCSS, $app)) {
                                        // Inject icons vars css if any
-                                       $this->lockingCache->remove($lockKey);
                                        $this->logger->debug("SCSSCacher::process cached file for app '$app' and file '$fileNameCSS' is now available after $retry s. Moving on...", ['app' => 'scss_cacher']);
                                        return $this->injectCssVariablesIfAny();
                                }