Return explicit values instead of boolean from sabre (#26654)

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>

diff --git a/apps/dav/lib/Connector/Sabre/TagsPlugin.php b/apps/dav/lib/Connector/Sabre/TagsPlugin.php
index ef6bece58bc1413fd3309d7e0d49f5093848b888..59e4ab4546deb6dc35a5992ea5db724b6566b4c9 100644 (file)
--- a/apps/dav/lib/Connector/Sabre/TagsPlugin.php
+++ b/apps/dav/lib/Connector/Sabre/TagsPlugin.php
@@ -250,7 +250,11 @@ class TagsPlugin extends \Sabre\DAV\ServerPlugin
                        if (is_null($isFav)) {
                                list(, $isFav) = $this->getTagsAndFav($node->getId());
                        }
-                       return $isFav;
+                       if ($isFav) {
+                               return 1;
+                       } else {
+                               return 0;
+                       }
                });
        }
 

diff --git a/build/integration/features/favorites.feature b/build/integration/features/favorites.feature
index 5e31e1902f81f63c5a12ddb51994b448df0bd412..88bbf81a93441179ced5b5315243484248a1ad3f 100644 (file)
--- a/build/integration/features/favorites.feature
+++ b/build/integration/features/favorites.feature
@@ -19,7 +19,7 @@ Feature: favorite
         And user "user0" unfavorites element "/FOLDER"
         Then as "user0" gets properties of folder "/FOLDER" with
             |{http://owncloud.org/ns}favorite|
-        And the single response should contain a property "{http://owncloud.org/ns}favorite" with value ""
+        And the single response should contain a property "{http://owncloud.org/ns}favorite" with value "0"
 
     Scenario: Favorite a file
         Given using old dav path
@@ -38,7 +38,7 @@ Feature: favorite
         And user "user0" unfavorites element "/textfile0.txt"
         Then as "user0" gets properties of file "/textfile0.txt" with
             |{http://owncloud.org/ns}favorite|
-        And the single response should contain a property "{http://owncloud.org/ns}favorite" with value ""
+        And the single response should contain a property "{http://owncloud.org/ns}favorite" with value "0"
 
     Scenario: Favorite a folder new endpoint
         Given using new dav path
@@ -57,7 +57,7 @@ Feature: favorite
         And user "user0" unfavorites element "/FOLDER"
         Then as "user0" gets properties of folder "/FOLDER" with
             |{http://owncloud.org/ns}favorite|
-        And the single response should contain a property "{http://owncloud.org/ns}favorite" with value ""
+        And the single response should contain a property "{http://owncloud.org/ns}favorite" with value "0"
 
     Scenario: Favorite a file new endpoint
         Given using new dav path
@@ -76,5 +76,5 @@ Feature: favorite
         And user "user0" unfavorites element "/textfile0.txt"
         Then as "user0" gets properties of file "/textfile0.txt" with
             |{http://owncloud.org/ns}favorite|
-        And the single response should contain a property "{http://owncloud.org/ns}favorite" with value ""
+        And the single response should contain a property "{http://owncloud.org/ns}favorite" with value "0"