Improve LFS error logs (#24072) (#24082)

Backport #24072 by @wxiaoguang

The error logs were not clear.

Help (but not fix) #24053

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

diff --git a/services/lfs/server.go b/services/lfs/server.go
index 758f4ebfe0c57f2bf42f7333609c490cc28d215e..d63d08ce0181a194129af1dfb22bdc0ae3dadf5e 100644 (file)
--- a/services/lfs/server.go
+++ b/services/lfs/server.go
@@ -126,7 +126,6 @@ func DownloadHandler(ctx *context.Context) {
                _, err = content.Seek(fromByte, io.SeekStart)
                if err != nil {
                        log.Error("Whilst trying to read LFS OID[%s]: Unable to seek to %d Error: %v", meta.Oid, fromByte, err)
-
                        writeStatus(ctx, http.StatusInternalServerError)
                        return
                }
@@ -334,10 +333,11 @@ func UploadHandler(ctx *context.Context) {
                        log.Error("Upload does not match LFS MetaObject [%s]. Error: %v", p.Oid, err)
                        writeStatusMessage(ctx, http.StatusUnprocessableEntity, err.Error())
                } else {
+                       log.Error("Error whilst uploadOrVerify LFS OID[%s]: %v", p.Oid, err)
                        writeStatus(ctx, http.StatusInternalServerError)
                }
                if _, err = git_model.RemoveLFSMetaObjectByOid(ctx, repository.ID, p.Oid); err != nil {
-                       log.Error("Error whilst removing metaobject for LFS OID[%s]: %v", p.Oid, err)
+                       log.Error("Error whilst removing MetaObject for LFS OID[%s]: %v", p.Oid, err)
                }
                return
        }
@@ -365,6 +365,7 @@ func VerifyHandler(ctx *context.Context) {
 
        status := http.StatusOK
        if err != nil {
+               log.Error("Error whilst verifying LFS OID[%s]: %v", p.Oid, err)
                status = http.StatusInternalServerError
        } else if !ok {
                status = http.StatusNotFound