]> source.dussan.org Git - jquery.git/commitdiff
Revert "Deferred: add .catch handler"
authorOleg Gaidarenko <markelog@gmail.com>
Wed, 11 Nov 2015 16:07:21 +0000 (19:07 +0300)
committerOleg Gaidarenko <markelog@gmail.com>
Wed, 11 Nov 2015 16:07:21 +0000 (19:07 +0300)
This reverts commit 84ccf2606c6b97d5875774bf774f9f2aae950ae7.

src/deferred.js
test/unit/deferred.js

index e1af425d483bed28250d93b90a765515444c6464..6c85dd6fdd1163690b083b6b5978f4b94aee1f45 100644 (file)
@@ -34,9 +34,6 @@ jQuery.extend( {
                                        deferred.done( arguments ).fail( arguments );
                                        return this;
                                },
-                               "catch": function( fn ) {
-                                       return promise.then( null, fn );
-                               },
 
                                // Keep pipe for back-compat
                                pipe: function( /* fnDone, fnFail, fnProgress */ ) {
index 2277df1903188a458b780d351e1b3369e42deac0..a71273727602326a0076430b5855b01656082a3f 100644 (file)
@@ -166,42 +166,6 @@ QUnit.test( "jQuery.Deferred.then - filtering (fail)", function( assert ) {
        } );
 } );
 
-QUnit.test( "jQuery.Deferred.catch", function( assert ) {
-       assert.expect( 4 );
-
-       var value1, value2, value3,
-               defer = jQuery.Deferred(),
-               piped = defer[ "catch" ]( function( a, b ) {
-                       return a * b;
-               } ),
-               done = jQuery.map( new Array( 3 ), function() { return assert.async(); } );
-
-       piped.done( function( result ) {
-               value3 = result;
-       } );
-
-       defer.fail( function( a, b ) {
-               value1 = a;
-               value2 = b;
-       } );
-
-       defer.reject( 2, 3 )[ "catch" ]( function() {
-               assert.strictEqual( value1, 2, "first reject value ok" );
-               assert.strictEqual( value2, 3, "second reject value ok" );
-               assert.strictEqual( value3, 6, "result of filter ok" );
-               done.pop().call();
-       } );
-
-       jQuery.Deferred().resolve()[ "catch" ]( function() {
-               assert.ok( false, "then should not be called on resolve" );
-       } ).then( done.pop() );
-
-       jQuery.Deferred().reject()[ "catch" ]( jQuery.noop ).done( function( value ) {
-               assert.strictEqual( value, undefined, "then fail callback can return undefined/null" );
-               done.pop().call();
-       } );
-} );
-
 QUnit.test( "[PIPE ONLY] jQuery.Deferred.pipe - filtering (fail)", function( assert ) {
 
        assert.expect( 4 );