Fixed #6979 - Several components are leaking variables into the global scope

diff --git a/ui/jquery.effects.pulsate.js b/ui/jquery.effects.pulsate.js
index 8eb9990176c8a9810a3ad52aa487c5c948b78b6e..1b3cb00f8913ccd3e12582239f076216919125f6 100644 (file)
--- a/ui/jquery.effects.pulsate.js
+++ b/ui/jquery.effects.pulsate.js
@@ -15,8 +15,8 @@
 $.effects.pulsate = function(o) {
        return this.queue(function() {
                var elem = $(this),
-                       mode = $.effects.setMode(elem, o.options.mode || 'show');
-                       times = ((o.options.times || 5) * 2) - 1;
+                       mode = $.effects.setMode(elem, o.options.mode || 'show'),
+                       times = ((o.options.times || 5) * 2) - 1,
                        duration = o.duration ? o.duration / 2 : $.fx.speeds._default / 2,
                        isVisible = elem.is(':visible'),
                        animateTo = 0;

diff --git a/ui/jquery.effects.scale.js b/ui/jquery.effects.scale.js
index 281021380fb0676c02e0aa71917642c95c009bcf..9a4020d58053ef4f85a0b440e3fa9385da69e011 100644 (file)
--- a/ui/jquery.effects.scale.js
+++ b/ui/jquery.effects.scale.js
@@ -140,7 +140,7 @@ $.effects.size = function(o) {
                        hProps = hProps.concat(['marginLeft','marginRight']); // Add margins
                        props2 = props.concat(vProps).concat(hProps); // Concat
                        el.find("*[width]").each(function(){
-                               child = $(this);
+                               var child = $(this);
                                if (restore) $.effects.save(child, props2);
                                var c_original = {height: child.height(), width: child.width()}; // Save original
                                child.from = {height: c_original.height * factor.from.y, width: c_original.width * factor.from.x};

diff --git a/ui/jquery.ui.accordion.js b/ui/jquery.ui.accordion.js
index 8049868e876f2bc5b73152e8b789757bc9c998f8..34327be279ede23bd3557b01557da9e852c51ac1 100644 (file)
--- a/ui/jquery.ui.accordion.js
+++ b/ui/jquery.ui.accordion.js
@@ -542,7 +542,7 @@ if ( $.uiBackCompat !== false ) {
                        if ( this.options.navigation ) {
                                var self = this,
                                        headers = this.element.find( this.options.header ),
-                                       content = headers.next();
+                                       content = headers.next(),
                                        current = headers.add( content )
                                                .find( "a" )
                                                .filter( this.options.navigationFilter )

diff --git a/ui/jquery.ui.slider.js b/ui/jquery.ui.slider.js
index f6bc570256fbde6dffbf6901923343eb9eac01f5..38c5996d0f47a7ebdbe43ac5ca5e26db81797acc 100644 (file)
--- a/ui/jquery.ui.slider.js
+++ b/ui/jquery.ui.slider.js
@@ -592,7 +592,7 @@ $.widget( "ui.slider", $.ui.mouse, {
                        return this._valueMax();
                }
                var step = ( this.options.step > 0 ) ? this.options.step : 1,
-                       valModStep = (val - this._valueMin()) % step;
+                       valModStep = (val - this._valueMin()) % step,
                        alignValue = val - valModStep;
 
                if ( Math.abs(valModStep) * 2 >= step ) {