Fix PHPdoc in apps/files_sharing

using scrutinizer patch

diff --git a/apps/files_sharing/lib/cache.php b/apps/files_sharing/lib/cache.php
index eeb62c3cce2c0c6f4348010cde2130163e1fcd94..b9c5e8f60aa21e801e0840a67c77984bb274177f 100644 (file)
--- a/apps/files_sharing/lib/cache.php
+++ b/apps/files_sharing/lib/cache.php
@@ -422,6 +422,9 @@ class Shared_Cache extends Cache {
                }
        }
 
+       /**
+        * @param integer $id
+        */
        private function getShareById($id) {
                $item = \OCP\Share::getItemSharedWithBySource('file', $id);
                if ($item) {
@@ -434,6 +437,9 @@ class Shared_Cache extends Cache {
                return null;
        }
 
+       /**
+        * @param integer $id
+        */
        private function getParentInfo($id) {
                $sql = 'SELECT `parent`, `name` FROM `*PREFIX*filecache` WHERE `fileid` = ?';
                $query = \OC_DB::prepare($sql);

diff --git a/apps/files_sharing/lib/helper.php b/apps/files_sharing/lib/helper.php
index b602fe3599d0888c27ef589f52d774f1c904a15b..cba0ef2a0a4d4a609687a98aa365808ea8bc789d 100644 (file)
--- a/apps/files_sharing/lib/helper.php
+++ b/apps/files_sharing/lib/helper.php
@@ -80,7 +80,7 @@ class Helper {
         * @param array $linkItem link item array
         * @param string $password optional password
         *
-        * @return true if authorized, false otherwise
+        * @return boolean true if authorized, false otherwise
         */
        public static function authenticate($linkItem, $password) {
                if ($password !== null) {

diff --git a/apps/files_sharing/lib/share/file.php b/apps/files_sharing/lib/share/file.php
index 5e00050fe1e9f5aa79584317c3806f8ef3ccb887..c375579b1a23d97c37e669d995da3574d10460fb 100644 (file)
--- a/apps/files_sharing/lib/share/file.php
+++ b/apps/files_sharing/lib/share/file.php
@@ -146,6 +146,9 @@ class OC_Share_Backend_File implements OCP\Share_Backend_File_Dependent {
                return array();
        }
 
+       /**
+        * @param string $target
+        */
        public static function getSource($target) {
                if ($target == '') {
                        return false;

diff --git a/apps/files_sharing/tests/api.php b/apps/files_sharing/tests/api.php
index c7a848315ac8e7231ab151119ae72611e89f69f2..d9a21fa959b03932820d28705885d99b0249bb5d 100644 (file)
--- a/apps/files_sharing/tests/api.php
+++ b/apps/files_sharing/tests/api.php
@@ -907,6 +907,11 @@ class Test_Files_Sharing_Api extends Test_Files_Sharing_Base {
  * @brief dumnmy class to test protected methods
  */
 class TestShareApi extends \OCA\Files\Share\Api {
+
+       /**
+        * @param string $path
+        * @param string $folder
+        */
        public function correctPathTest($path, $folder) {
                return self::correctPath($path, $folder);
        }