Don't swallow exceptions on validation

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1641025 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/SignatureInfo.java b/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/SignatureInfo.java
index bf9dae94f53c0f19f307dd168ffae1b5ab3f150b..c6efe6077d72970b749b0d537d2da644c23c9698 100644 (file)
--- a/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/SignatureInfo.java
+++ b/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/SignatureInfo.java
@@ -217,7 +217,10 @@ public class SignatureInfo implements SignatureConfigurable {
         \r
         /**\r
          * @return true, when the xml signature is valid, false otherwise\r
+         * \r
+         * @throws EncryptedDocumentException if the signature can't be extracted or if its malformed\r
          */\r
+        @SuppressWarnings("unchecked")\r
         public boolean validate() {\r
             KeyInfoKeySelector keySelector = new KeyInfoKeySelector();\r
             try {\r
@@ -259,8 +262,9 @@ public class SignatureInfo implements SignatureConfigurable {
                 \r
                 return valid;\r
             } catch (Exception e) {\r
-                LOG.log(POILogger.ERROR, "error in marshalling and validating the signature", e);\r
-                return false;\r
+                String s = "error in marshalling and validating the signature";\r
+                LOG.log(POILogger.ERROR, s, e);\r
+                throw new EncryptedDocumentException(s, e);\r
             }\r
         }\r
     }\r