allow nodes that are not imported yet (fixes #1252)

diff --git a/spec/spec/utils/adopter.js b/spec/spec/utils/adopter.js
index 3c12790fdf9219fa71a34aabbde17020b63acec4..b158be5b4ec23d2b7301edf14adee2093eb165b9 100644 (file)
--- a/spec/spec/utils/adopter.js
+++ b/spec/spec/utils/adopter.js
@@ -22,6 +22,7 @@ import {
 import { mockAdopt, assignNewId, adopt } from '../../../src/utils/adopter.js'
 import { buildFixtures } from '../../helpers.js'
 import { globals, getWindow } from '../../../src/utils/window.js'
+import { svg } from '../../../src/modules/core/namespaces.js'
 
 const { any, createSpy, objectContaining } = jasmine
 
@@ -172,6 +173,18 @@ describe('adopter.js', () => {
       // jasmine chucks on this when using the node directly
       expect(node.outerHTML).toBe(div.outerHTML)
     })
+
+    it('gracefully handles nodes that are not yet imported into the document', () => {
+      const otherDoc = globals.document.implementation.createDocument(
+        svg,
+        'svg'
+      )
+      const rect = otherDoc.createElementNS(svg, 'rect')
+
+      const node = nodeOrNew('rect', rect)
+
+      expect(node).toEqual(rect)
+    })
   })
 
   describe('register()/getClass()', () => {

diff --git a/src/utils/adopter.js b/src/utils/adopter.js
index 48814ec66fdb05204bb05ecc77d33527137eb01b..962412fd201556f4f231a973ab85841c806a34d1 100644 (file)
--- a/src/utils/adopter.js
+++ b/src/utils/adopter.js
@@ -43,8 +43,9 @@ export function makeInstance(element, isHTML = false) {
 
 export function nodeOrNew(name, node) {
   return node &&
-    node.ownerDocument &&
-    node instanceof node.ownerDocument.defaultView.Node
+    (node instanceof globals.window.Node ||
+      (node.ownerDocument &&
+        node instanceof node.ownerDocument.defaultView.Node))
     ? node
     : create(name)
 }