]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-7283 Drop remaining useless events WS definition
authorJulien Lancelot <julien.lancelot@sonarsource.com>
Mon, 2 Jan 2017 14:05:41 +0000 (15:05 +0100)
committerJulien Lancelot <julien.lancelot@sonarsource.com>
Mon, 2 Jan 2017 16:43:24 +0000 (17:43 +0100)
server/sonar-server/src/main/java/org/sonar/server/authentication/JwtCsrfVerifier.java
server/sonar-server/src/main/java/org/sonar/server/component/ws/ComponentsWsModule.java
server/sonar-server/src/main/java/org/sonar/server/component/ws/EventsWs.java [deleted file]
server/sonar-server/src/test/java/org/sonar/server/component/ws/ComponentsWsModuleTest.java
server/sonar-server/src/test/java/org/sonar/server/component/ws/EventsWsTest.java [deleted file]

index 88c2180a190e71219b31d7a52a695cb3874c7e98..a467cf8353c3b3f4c46cf2fe85212fe3aab5a025 100644 (file)
@@ -43,7 +43,6 @@ public class JwtCsrfVerifier {
   private static final Set<String> UPDATE_METHODS = ImmutableSet.of("POST", "PUT", "DELETE");
   private static final String API_URL = "/api";
   private static final Set<String> RAILS_UPDATE_API_URLS = ImmutableSet.of(
-    "/api/events",
     "/api/issues/add_comment",
     "/api/issues/delete_comment",
     "/api/issues/edit_comment",
index 76933a91e208ebdcbe91183e3bae725775fc558a..de9fadd817f7c3c852e0ac6c1c5ac25aba2c2280 100644 (file)
@@ -27,7 +27,6 @@ public class ComponentsWsModule extends Module {
     add(
       ResourcesWs.class,
       ComponentsWs.class,
-      EventsWs.class,
       // actions
       AppAction.class,
       SearchAction.class,
diff --git a/server/sonar-server/src/main/java/org/sonar/server/component/ws/EventsWs.java b/server/sonar-server/src/main/java/org/sonar/server/component/ws/EventsWs.java
deleted file mode 100644 (file)
index aa622e7..0000000
+++ /dev/null
@@ -1,46 +0,0 @@
-/*
- * SonarQube
- * Copyright (C) 2009-2016 SonarSource SA
- * mailto:contact AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
- */
-package org.sonar.server.component.ws;
-
-import org.sonar.api.server.ws.RailsHandler;
-import org.sonar.api.server.ws.WebService;
-
-public class EventsWs implements WebService {
-
-  @Override
-  public void define(Context context) {
-    NewController controller = context.createController("api/events");
-    controller.setDescription("Manage project events.");
-    controller.setSince("2.6");
-
-    defineIndexAction(controller);
-
-    controller.done();
-  }
-
-  private void defineIndexAction(NewController controller) {
-    WebService.NewAction action = controller.createAction("index")
-      .setDescription("Documentation of this web service is available <a href=\"http://redirect.sonarsource.com/doc/old-web-service-api.html\">here</a>")
-      .setResponseExample(getClass().getResource("events-index-example.json"))
-      .setSince("2.6")
-      .setHandler(RailsHandler.INSTANCE);
-    RailsHandler.addFormatParam(action);
-  }
-}
index f8dee7ef5f4b3dc94fb2c2aea283f347cbb8aa27..a126f8c618271f68ca39c4c810088f1304974b15 100644 (file)
@@ -29,6 +29,6 @@ public class ComponentsWsModuleTest {
   public void verify_count_of_added_components() {
     ComponentContainer container = new ComponentContainer();
     new ComponentsWsModule().configure(container);
-    assertThat(container.size()).isEqualTo(12 + 2);
+    assertThat(container.size()).isEqualTo(11 + 2);
   }
 }
diff --git a/server/sonar-server/src/test/java/org/sonar/server/component/ws/EventsWsTest.java b/server/sonar-server/src/test/java/org/sonar/server/component/ws/EventsWsTest.java
deleted file mode 100644 (file)
index 67239b3..0000000
+++ /dev/null
@@ -1,39 +0,0 @@
-/*
- * SonarQube
- * Copyright (C) 2009-2016 SonarSource SA
- * mailto:contact AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
- */
-package org.sonar.server.component.ws;
-
-import org.junit.Test;
-import org.sonar.api.server.ws.WebService;
-import org.sonar.server.ws.WsTester;
-
-import static org.assertj.core.api.Assertions.assertThat;
-
-public class EventsWsTest {
-
-  WsTester tester = new WsTester(new EventsWs());
-
-  @Test
-  public void define_ws() {
-    WebService.Controller controller = tester.controller("api/events");
-    assertThat(controller).isNotNull();
-    assertThat(controller.description()).isNotEmpty();
-    assertThat(controller.actions()).hasSize(1);
-  }
-}