[Patch] Fix closed PR also triggers Webhooks and actions (#23782) (#23834)

Backport #23782 by @sillyguodong

Fix #23707
Cause by #23189
This PR is a quick fix that, when pushing commits to closed PR, webhook
and actions also be triggered.

Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com>

diff --git a/services/pull/pull.go b/services/pull/pull.go
index a5541b84606b2736f9450bf15d62f18333472359..73d7c571484c2cc63a08abdeab803ca1a0bda99f 100644 (file)
--- a/services/pull/pull.go
+++ b/services/pull/pull.go
@@ -294,6 +294,10 @@ func AddTestPullRequestTask(doer *user_model.User, repoID int64, branch string,
                        }
                        if err == nil {
                                for _, pr := range prs {
+                                       if pr.Issue.IsClosed {
+                                               // The closed PR never trigger action or webhook
+                                               continue
+                                       }
                                        if newCommitID != "" && newCommitID != git.EmptySHA {
                                                changed, err := checkIfPRContentChanged(ctx, pr, oldCommitID, newCommitID)
                                                if err != nil {