Fix quality flaws

diff --git a/sonar-server/src/test/java/org/sonar/server/source/OpeningHtmlTagTest.java b/sonar-server/src/test/java/org/sonar/server/source/OpeningHtmlTagTest.java
new file mode 100644 (file)
index 0000000..eddea84
--- /dev/null
+++ b/sonar-server/src/test/java/org/sonar/server/source/OpeningHtmlTagTest.java
@@ -0,0 +1,60 @@
+/*
+ * SonarQube, open source software quality management tool.
+ * Copyright (C) 2008-2013 SonarSource
+ * mailto:contact AT sonarsource DOT com
+ *
+ * SonarQube is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * SonarQube is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+
+package org.sonar.server.source;
+
+import org.junit.Test;
+
+import static org.fest.assertions.Assertions.assertThat;
+
+public class OpeningHtmlTagTest {
+
+  @Test
+  public void test_getters() throws Exception {
+    OpeningHtmlTag openingHtmlTag = new OpeningHtmlTag(3, "tag");
+    assertThat(openingHtmlTag.getStartOffset()).isEqualTo(3);
+    assertThat(openingHtmlTag.getCssClass()).isEqualTo("tag");
+  }
+
+  @Test
+  public void test_equals() throws Exception {
+    OpeningHtmlTag openingHtmlTag = new OpeningHtmlTag(3, "tag");
+    OpeningHtmlTag openingHtmlTagWithSameValues = new OpeningHtmlTag(3, "tag");
+    OpeningHtmlTag openingHtmlTagWithDifferentValues = new OpeningHtmlTag(5, "tag2");
+    OpeningHtmlTag openingHtmlTagWithNoCssClass = new OpeningHtmlTag(3, null);
+
+    assertThat(openingHtmlTag).isEqualTo(openingHtmlTagWithSameValues);
+    assertThat(openingHtmlTag).isEqualTo(openingHtmlTag);
+    assertThat(openingHtmlTag).isNotEqualTo(openingHtmlTagWithDifferentValues);
+    assertThat(openingHtmlTag).isNotEqualTo(openingHtmlTagWithNoCssClass);
+    assertThat(openingHtmlTag).isNotEqualTo(new OpeningHtmlTag(3, "tag"){});
+  }
+
+  @Test
+  public void test_hashcode() throws Exception {
+    OpeningHtmlTag openingHtmlTag = new OpeningHtmlTag(3, "tag");
+    OpeningHtmlTag openingHtmlTagWithSameValues = new OpeningHtmlTag(3, "tag");
+    OpeningHtmlTag openingHtmlTagWithDifferentValue = new OpeningHtmlTag(5, "tag2");
+
+    assertThat(openingHtmlTag.hashCode()).isEqualTo(openingHtmlTagWithSameValues.hashCode());
+    assertThat(openingHtmlTag.hashCode()).isEqualTo(openingHtmlTag.hashCode());
+    assertThat(openingHtmlTag.hashCode()).isNotEqualTo(openingHtmlTagWithDifferentValue.hashCode());
+  }
+}

diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/internal/DefaultIssueClient.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/internal/DefaultIssueClient.java
index b9c5ae350afda4800cd295408503dc66e867d9df..248a38ab915fcbc0fa41e9ebeabe261d9c27e027 100644 (file)
--- a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/internal/DefaultIssueClient.java
+++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/internal/DefaultIssueClient.java
@@ -35,6 +35,7 @@ import java.util.Map;
 public class DefaultIssueClient implements IssueClient {
 
   private static final String SEARCH_URL = "/api/issues/search";
+  private static final String ASSIGN_URL = "/api/issues/assign";
 
   private final HttpRequestFactory requestFactory;
   private final IssueJsonParser parser;
@@ -72,7 +73,7 @@ public class DefaultIssueClient implements IssueClient {
   @Override
   public Issue assignToMe(String issueKey) {
     Map<String, Object> params = EncodingUtils.toMap("issue", issueKey, "me", "true");
-    String json = requestFactory.post("/api/issues/assign", params);
+    String json = requestFactory.post(ASSIGN_URL, params);
     return jsonToIssue(json);
   }