]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-5967 Remove the limitation of 3000 lines
authorStas Vilchik <vilchiks@gmail.com>
Tue, 23 Dec 2014 13:35:01 +0000 (14:35 +0100)
committerStas Vilchik <vilchiks@gmail.com>
Tue, 23 Dec 2014 13:35:01 +0000 (14:35 +0100)
server/sonar-web/src/main/coffee/component-viewer/source.coffee
server/sonar-web/src/main/hbs/component-viewer/cw-source.hbs
sonar-core/src/main/resources/org/sonar/l10n/core.properties

index 42ae5c0571980d33fb98b372301b6cc4dc1e526b..079566287a63a1d0fb7f45064caea2f39fea3583 100644 (file)
@@ -24,7 +24,6 @@ define [
   $ = jQuery
 
   API_COVERAGE_TESTS = "#{baseUrl}/api/tests/test_cases"
-  LINES_LIMIT = 3000
   ISSUES_LIMIT = 100
 
 
@@ -104,7 +103,6 @@ define [
         $(expand).insertBefore rows.first()
 
       lines = _.size @model.get 'source'
-      lines = Math.min lines, LINES_LIMIT
       lastShown = rows.last().data('line-number')
       if lastShown < lines
         expand = @expandTemplate
@@ -311,17 +309,16 @@ define [
       source.forEach (sourceLine) =>
         show = false
         line = sourceLine.lineNumber
-        if line <= LINES_LIMIT
-          @showBlocks.forEach (block) ->
-            show = true if block.from <= line && block.to >= line
-          _.extend sourceLine, show: show
+        @showBlocks.forEach (block) ->
+          show = true if block.from <= line && block.to >= line
+        _.extend sourceLine, show: show
       source
 
 
     prepareSource: ->
       source = @model.get 'formattedSource'
       if source?
-        _.first @augmentWithShow(source), LINES_LIMIT
+        @augmentWithShow(source)
 
 
     getStatColumnsCount: ->
@@ -359,6 +356,4 @@ define [
       showZeroLine: @showZeroLine()
       issuesLimit: ISSUES_LIMIT
       issuesLimitReached: @model.get('activeIssues')?.length > ISSUES_LIMIT
-      linesLimit: LINES_LIMIT
-      linesLimitReached: _.size(@model.get 'source') > LINES_LIMIT
       baseDuplications: @getBaseDuplications()
index dbb80fcf7cf8adbd7556a6a1d729c179da6daf6e..7fb13a6bee83a5eec05665cdade88be76b05666e 100644 (file)
@@ -4,10 +4,6 @@
 
 {{else}}
 
-  {{#if linesLimitReached}}
-    <p class="message-alert marginbottom10">{{tp 'component_viewer.lines_limit_reached' linesLimit}}</p>
-  {{/if}}
-
   {{#if issuesLimitReached}}
     <p class="message-alert marginbottom10">{{tp 'component_viewer.issues_limit_reached' issuesLimit}}</p>
   {{/if}}
index 0b6a9905610ba928714bbd1380ea6a3af221730a..ade5dec40c9842a985e4d8e04143e6f6ee730afc 100644 (file)
@@ -2755,7 +2755,6 @@ component_viewer.more_actions=More Actions
 component_viewer.new_window=Open in New Window
 component_viewer.get_permalink=Get Permalink
 component_viewer.covered_lines=Covered Lines
-component_viewer.lines_limit_reached=For performance reasons, only the {0} first lines will be displayed.
 component_viewer.issues_limit_reached=For usability reasons, only the {0} first issues will be fully displayed. Remaining issues will simply be underlined.
 component_viewer.issues_limit_reached_tooltip={0}\n\nRefine your filter to be able to see the details of this issue.
 component_viewer.cannot_show=We're sorry, but something went wrong. Please try back in a few minutes and contact support if the problem persists.