]> source.dussan.org Git - vaadin-framework.git/commitdiff
Added null checks for callbacks in BundleLoader (#9648)
authorArtur Signell <artur@vaadin.com>
Tue, 18 Sep 2012 07:49:37 +0000 (10:49 +0300)
committerArtur Signell <artur@vaadin.com>
Tue, 18 Sep 2012 09:43:26 +0000 (12:43 +0300)
client/src/com/vaadin/client/metadata/AsyncBundleLoader.java
client/src/com/vaadin/client/metadata/ConnectorBundleLoader.java

index 7bbd93c6e38c7a8fa10f278c4b080f291792da73..2073ab7aab28a0ce8fecc5f3ebbbdf9b62cc4b9f 100644 (file)
@@ -53,13 +53,15 @@ public abstract class AsyncBundleLoader {
     public void load(BundleLoadCallback callback, TypeDataStore store) {
         assert state == State.NOT_STARTED;
         state = State.LOADING;
-        callbacks.add(callback);
+        addCallback(callback);
         load(store);
     }
 
     public void addCallback(BundleLoadCallback callback) {
         assert state == State.LOADING;
-        callbacks.add(callback);
+        if (callback != null) {
+            callbacks.add(callback);
+        }
     }
 
     public List<BundleLoadCallback> setLoaded() {
index 7d6c209ebf55e8948feafca79ba4a6b6cbab8108..0549547e386114477797c5083c7a1a75bdc6160e 100644 (file)
@@ -47,10 +47,14 @@ public abstract class ConnectorBundleLoader {
             loader.addCallback(callback);
             break;
         case LOADED:
-            callback.loaded();
+            if (callback != null) {
+                callback.loaded();
+            }
             break;
         case ERROR:
-            callback.failed(loader.getError());
+            if (callback != null) {
+                callback.failed(loader.getError());
+            }
         }
     }