replace some "new ArrayList<GENERIC>()" with Lists.newArrayList() of google guava

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/qualitymodel/Characteristic.java b/sonar-plugin-api/src/main/java/org/sonar/api/qualitymodel/Characteristic.java
index 4a1053c88a2ea4ab084de8e0457a18a987450e20..8555dbd0b220f464bef97d6d0d81e6a546cf8f92 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/qualitymodel/Characteristic.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/qualitymodel/Characteristic.java
@@ -19,6 +19,7 @@
  */
 package org.sonar.api.qualitymodel;
 
+import com.google.common.collect.Lists;
 import org.apache.commons.lang.StringUtils;
 import org.apache.commons.lang.builder.ToStringBuilder;
 import org.apache.commons.lang.builder.ToStringStyle;
@@ -27,7 +28,6 @@ import org.hibernate.annotations.SortType;
 import org.sonar.api.rules.Rule;
 
 import javax.persistence.*;
-import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
 
@@ -78,14 +78,14 @@ public final class Characteristic implements Comparable<Characteristic> {
       inverseJoinColumns = @JoinColumn(name = "parent_id",
           referencedColumnName = "id")
   )
-  private List<Characteristic> parents = new ArrayList<Characteristic>();
+  private List<Characteristic> parents = Lists.newArrayList();
 
   @Sort(type = SortType.NATURAL)
   @ManyToMany(mappedBy = "parents", cascade = CascadeType.ALL)
-  private List<Characteristic> children = new ArrayList<Characteristic>();
+  private List<Characteristic> children = Lists.newArrayList();
 
   @OneToMany(mappedBy = "characteristic", fetch = FetchType.LAZY, cascade = {CascadeType.MERGE, CascadeType.PERSIST, CascadeType.REMOVE})
-  private List<CharacteristicProperty> properties = new ArrayList<CharacteristicProperty>();
+  private List<CharacteristicProperty> properties = Lists.newArrayList();
 
   Characteristic() {
   }

diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/batch/AbstractSourceImporterTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/batch/AbstractSourceImporterTest.java
index db0de75b8dd72bd725b7bbc5900616913b7387a0..d0048d72e0c6ff89354ecbe539696f262fc1e1d9 100644 (file)
--- a/sonar-plugin-api/src/test/java/org/sonar/api/batch/AbstractSourceImporterTest.java
+++ b/sonar-plugin-api/src/test/java/org/sonar/api/batch/AbstractSourceImporterTest.java
@@ -41,6 +41,7 @@ import java.util.Arrays;
 import java.util.HashMap;
 import java.util.List;
 
+import com.google.common.collect.Lists;
 import org.apache.commons.configuration.Configuration;
 import org.apache.commons.configuration.MapConfiguration;
 import org.apache.commons.configuration.PropertiesConfiguration;
@@ -168,7 +169,7 @@ public class AbstractSourceImporterTest {
 
     File unitTestFile = new File("test/UnitTest.java");
     File unitTestDir = new File("test");
-    List<File> unitTestDirs = new ArrayList<File>();
+    List<File> unitTestDirs = Lists.newArrayList();
     unitTestDirs.add(unitTestDir);
 
     Resource unitTest = importer.createResource(unitTestFile, unitTestDirs, true);