@CheckForNull
@Override
public CodeCharacteristic characteristic() {
- throw new IllegalStateException("Not implemented yet");
+ return null;
}
public DefaultIssue setType(RuleType type) {
@CheckForNull
@Override
public CodeCharacteristic characteristic() {
- throw new IllegalStateException("Not implemented yet");
+ return null;
}
@Override
@Override
public NewExternalIssue characteristic(CodeCharacteristic characteristic) {
- throw new IllegalStateException("Not implemented yet");
+ // no op
+ return this;
}
}
@CheckForNull
@Override
public CodeCharacteristic characteristic() {
- throw new IllegalStateException("Not implemented yet");
+ return null;
}
@Override
@Override
public NewAdHocRule characteristic(CodeCharacteristic characteristic) {
- throw new IllegalStateException("Not implemented yet");
+ // no op
+ return this;
}
}
.setWorkDir(temp.newFolder()));
}
-
private DefaultInputFile inputFile = new TestInputFileBuilder("foo", "src/Foo.php")
.initMetadata("Foo\nBar\n")
.build();
}
@Test
- public void characteristic_shouldThrowIllegalStateException() {
+ public void characteristic_shouldBeNoOp() {
SensorStorage storage = mock(SensorStorage.class);
DefaultExternalIssue issue = new DefaultExternalIssue(project, storage);
- assertThatThrownBy(issue::characteristic).isInstanceOf(IllegalStateException.class);
- assertThatThrownBy(() -> issue.characteristic(CodeCharacteristic.CLEAR)).isInstanceOf(IllegalStateException.class);
+ issue.characteristic(CodeCharacteristic.ROBUST);
+ assertThat(issue.characteristic()).isNull();
}
-
}
verify(storage).store(any(DefaultAdHocRule.class));
}
-
@Test
public void description_is_optional() {
SensorStorage storage = mock(SensorStorage.class);
.hasMessageContaining("Name is mandatory");
}
-
@Test
public void fail_to_store_if_no_severity() {
SensorStorage storage = mock(SensorStorage.class);
}
@Test
- public void characteristic_shouldThrowIllegalStateException() {
+ public void characteristic_shouldBeNoOp() {
SensorStorage storage = mock(SensorStorage.class);
DefaultAdHocRule rule = new DefaultAdHocRule(storage);
- assertThatThrownBy(() -> rule.characteristic(CodeCharacteristic.CLEAR)).isInstanceOf(IllegalStateException.class);
- assertThatThrownBy(() -> rule.characteristic()).isInstanceOf(IllegalStateException.class);
+ rule.characteristic(CodeCharacteristic.CLEAR);
+ assertThat(rule.characteristic()).isNull();
}
}