Block signals from being handled on worker threads

diff --git a/common/os/Thread.cxx b/common/os/Thread.cxx
index f38a10b7cbfd76b124311ea5ddc70aef8bbec946..2b08dbf976cc752b45e87a5b6610a4ca9fdddb46 100644 (file)
--- a/common/os/Thread.cxx
+++ b/common/os/Thread.cxx
@@ -20,6 +20,7 @@
 #include <windows.h>
 #else
 #include <pthread.h>
+#include <signal.h>
 #include <unistd.h>
 #endif
 
@@ -64,8 +65,19 @@ void Thread::start()
     throw rdr::SystemException("Failed to create thread", GetLastError());
 #else
   int ret;
+  sigset_t all, old;
+
+  // Creating threads from libraries is a bit evil, so mitigate the
+  // issue by at least avoiding signals on these threads
+  sigfillset(&all);
+  ret = pthread_sigmask(SIG_SETMASK, &all, &old);
+  if (ret != 0)
+    throw rdr::SystemException("Failed to mask signals", ret);
 
   ret = pthread_create((pthread_t*)threadId, NULL, startRoutine, this);
+
+  pthread_sigmask(SIG_SETMASK, &old, NULL);
+
   if (ret != 0)
     throw rdr::SystemException("Failed to create thread", ret);
 #endif