]> source.dussan.org Git - sonarqube.git/commitdiff
Ignore sonar.dynamicAnalysis in core coverage decorators
authorSimon Brandhof <simon.brandhof@sonarsource.com>
Wed, 25 Jun 2014 21:43:15 +0000 (23:43 +0200)
committerSimon Brandhof <simon.brandhof@sonarsource.com>
Wed, 25 Jun 2014 21:43:15 +0000 (23:43 +0200)
plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/AbstractCoverageDecorator.java
plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/CoverageDecoratorTest.java
plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ItCoverageDecoratorTest.java
plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ItLineCoverageDecoratorTest.java
plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/LineCoverageDecoratorTest.java
plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/OverallCoverageDecoratorTest.java
plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/OverallLineCoverageDecoratorTest.java

index e4153b67b16110c13223fb80d49aa5fe988f7afd..41973ea7239c2a965c2230a81e4fa471a23f5f15 100644 (file)
@@ -34,7 +34,7 @@ import java.util.Collection;
 public abstract class AbstractCoverageDecorator implements Decorator {
 
   public boolean shouldExecuteOnProject(Project project) {
-    return project.getAnalysisType().isDynamic(true);
+    return true;
   }
 
   @DependedUpon
index 2a3c3ead33c07392c7101a2c81bee93071dd7a85..4ca1bd15a5e9b2cb7e915fe582a62cfa5b87ebe4 100644 (file)
@@ -56,18 +56,6 @@ public class CoverageDecoratorTest {
         CoreMetrics.NEW_CONDITIONS_TO_COVER, CoreMetrics.NEW_UNCOVERED_CONDITIONS);
   }
 
-  @Test
-  public void noCoverageWhenStaticAnalysis() {
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.STATIC);
-    assertThat(new CoverageDecorator().shouldExecuteOnProject(project)).isFalse();
-
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.REUSE_REPORTS);
-    assertThat(new CoverageDecorator().shouldExecuteOnProject(project)).isTrue();
-
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.DYNAMIC);
-    assertThat(new CoverageDecorator().shouldExecuteOnProject(project)).isTrue();
-  }
-
   @Test
   public void coverage() {
     DecoratorContext context = mockContext(50, 40, 10, 8);
index 2ed500d0d70a779c9aff24cfab3308c5e4127d9b..3ceb343672a7da4e05df43e19caa59f916c9809e 100644 (file)
@@ -56,18 +56,6 @@ public class ItCoverageDecoratorTest {
         CoreMetrics.NEW_IT_CONDITIONS_TO_COVER, CoreMetrics.NEW_IT_UNCOVERED_CONDITIONS);
   }
 
-  @Test
-  public void noCoverageWhenStaticAnalysis() {
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.STATIC);
-    assertThat(new CoverageDecorator().shouldExecuteOnProject(project)).isFalse();
-
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.REUSE_REPORTS);
-    assertThat(new CoverageDecorator().shouldExecuteOnProject(project)).isTrue();
-
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.DYNAMIC);
-    assertThat(new CoverageDecorator().shouldExecuteOnProject(project)).isTrue();
-  }
-
   @Test
   public void coverage() {
     DecoratorContext context = mockContext(50, 40, 10, 8);
index 3bbf5352e2cbc7e224414c3d8b6afa48fe0e62d1..ccb7abcf907e476a0eb81808dcd9877c8adea2b5 100644 (file)
@@ -54,18 +54,6 @@ public class ItLineCoverageDecoratorTest {
     assertThat(metrics).containsOnly(CoreMetrics.IT_UNCOVERED_LINES, CoreMetrics.IT_LINES_TO_COVER, CoreMetrics.NEW_IT_UNCOVERED_LINES, CoreMetrics.NEW_IT_LINES_TO_COVER);
   }
 
-  @Test
-  public void noCoverageWhenStaticAnalysis() {
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.STATIC);
-    assertThat(decorator.shouldExecuteOnProject(project)).isFalse();
-
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.REUSE_REPORTS);
-    assertThat(decorator.shouldExecuteOnProject(project)).isTrue();
-
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.DYNAMIC);
-    assertThat(decorator.shouldExecuteOnProject(project)).isTrue();
-  }
-
   @Test
   public void lineCoverage() {
     DecoratorContext context = mockContext(50, 10);
index a0c12521f86ed16e2e7c9d13fa163065c02e6b10..4b89904efee094ac8d3ac41d82014f36216b16db 100644 (file)
@@ -54,18 +54,6 @@ public class LineCoverageDecoratorTest {
     assertThat(metrics).containsOnly(CoreMetrics.UNCOVERED_LINES, CoreMetrics.LINES_TO_COVER, CoreMetrics.NEW_UNCOVERED_LINES, CoreMetrics.NEW_LINES_TO_COVER);
   }
 
-  @Test
-  public void noCoverageWhenStaticAnalysis() {
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.STATIC);
-    assertThat(decorator.shouldExecuteOnProject(project)).isFalse();
-
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.REUSE_REPORTS);
-    assertThat(decorator.shouldExecuteOnProject(project)).isTrue();
-
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.DYNAMIC);
-    assertThat(decorator.shouldExecuteOnProject(project)).isTrue();
-  }
-
   @Test
   public void lineCoverage() {
     DecoratorContext context = mockContext(50, 10);
index 4dfdfd504fc0124c784a073de1a68864264509be..e4dbb3dbc9455acc308c2d015afe9d9f9ab955f8 100644 (file)
@@ -56,18 +56,6 @@ public class OverallCoverageDecoratorTest {
         CoreMetrics.NEW_OVERALL_CONDITIONS_TO_COVER, CoreMetrics.NEW_OVERALL_UNCOVERED_CONDITIONS);
   }
 
-  @Test
-  public void noCoverageWhenStaticAnalysis() {
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.STATIC);
-    assertThat(new CoverageDecorator().shouldExecuteOnProject(project)).isFalse();
-
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.REUSE_REPORTS);
-    assertThat(new CoverageDecorator().shouldExecuteOnProject(project)).isTrue();
-
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.DYNAMIC);
-    assertThat(new CoverageDecorator().shouldExecuteOnProject(project)).isTrue();
-  }
-
   @Test
   public void coverage() {
     DecoratorContext context = mockContext(50, 40, 10, 8);
index f761dc11e80eae64226d004b1f63a8efde51cae6..1b3c0db8a18c0f748e3a340ef051ba2b91203f53 100644 (file)
@@ -55,18 +55,6 @@ public class OverallLineCoverageDecoratorTest {
         CoreMetrics.NEW_OVERALL_LINES_TO_COVER);
   }
 
-  @Test
-  public void noCoverageWhenStaticAnalysis() {
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.STATIC);
-    assertThat(decorator.shouldExecuteOnProject(project)).isFalse();
-
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.REUSE_REPORTS);
-    assertThat(decorator.shouldExecuteOnProject(project)).isTrue();
-
-    when(project.getAnalysisType()).thenReturn(Project.AnalysisType.DYNAMIC);
-    assertThat(decorator.shouldExecuteOnProject(project)).isTrue();
-  }
-
   @Test
   public void lineCoverage() {
     DecoratorContext context = mockContext(50, 10);