]> source.dussan.org Git - vaadin-framework.git/commitdiff
#8040 Improved comment
authorJohannes Dahlström <johannes.dahlstrom@vaadin.com>
Fri, 16 Dec 2011 12:47:56 +0000 (12:47 +0000)
committerJohannes Dahlström <johannes.dahlstrom@vaadin.com>
Fri, 16 Dec 2011 12:47:56 +0000 (12:47 +0000)
svn changeset:22424/svn branch:6.7

src/com/vaadin/terminal/gwt/client/ui/VScrollTable.java

index d77507084d66bc9b1b92cf3f56ea7ce2a113307b..553934bf9809bdaf8214431d9baf746b64876ffd 100644 (file)
@@ -4052,8 +4052,15 @@ public class VScrollTable extends FlowPanel implements Table, ScrollHandler,
                 reactLastRow = totalRows - 1;
             }
             if (lastRendered < reactFirstRow || firstRendered > reactLastRow) {
-                // #8040 - scroll position is completely changed
-                // TODO: should probably be done earlier
+                /*
+                 * #8040 - scroll position is completely changed since the
+                 * latest request, so request a new set of rows.
+                 * 
+                 * TODO: We should probably check whether the fetched rows match
+                 * the current scroll position right when they arrive, so as to
+                 * not waste time rendering a set of rows that will never be
+                 * visible...
+                 */
                 rowRequestHandler.setReqFirstRow(reactFirstRow);
                 rowRequestHandler.setReqRows(reactLastRow - reactFirstRow + 1);
                 rowRequestHandler.deferRowFetch(1);