['own', :label_issues_visibility_own]
]
- scope :sorted, {:order => 'builtin, position'}
- scope :givable, { :conditions => "builtin = 0", :order => 'position' }
+ scope :sorted, order("#{table_name}.builtin ASC, #{table_name}.position ASC")
+ scope :givable, order("#{table_name}.position ASC").where(:builtin => 0)
scope :builtin, lambda { |*args|
- compare = 'not' if args.first == true
- { :conditions => "#{compare} builtin = 0" }
+ compare = (args.first == true ? 'not' : '')
+ where("#{compare} builtin = 0")
}
before_destroy :check_deletable
end
def <=>(role)
- role ? position <=> role.position : -1
+ if role
+ if builtin == role.builtin
+ position <=> role.position
+ else
+ builtin <=> role.builtin
+ end
+ else
+ -1
+ end
end
def to_s
# Find all the roles that can be given to a project member
def self.find_all_givable
- find(:all, :conditions => {:builtin => 0}, :order => 'position')
+ Role.givable.all
end
# Return the builtin 'non member' role. If the role doesn't exist,
end
def self.find_or_create_system_role(builtin, name)
- role = first(:conditions => {:builtin => builtin})
+ role = where(:builtin => builtin).first
if role.nil?
role = create(:name => name, :position => 0) do |r|
r.builtin = builtin
# Returns workflow transitions count by tracker and role
def self.count_by_tracker_and_role
counts = connection.select_all("SELECT role_id, tracker_id, count(id) AS c FROM #{Workflow.table_name} GROUP BY role_id, tracker_id")
- roles = Role.find(:all, :order => 'builtin, position')
- trackers = Tracker.find(:all, :order => 'position')
+ roles = Role.sorted.all
+ trackers = Tracker.sorted.all
result = []
trackers.each do |tracker|
class RoleTest < ActiveSupport::TestCase
fixtures :roles, :workflows
+ def test_sorted_scope
+ assert_equal Role.all.sort, Role.sorted.all
+ end
+
+ def test_givable_scope
+ assert_equal Role.all.reject(&:builtin?).sort, Role.givable.all
+ end
+
+ def test_builtin_scope
+ assert_equal Role.all.select(&:builtin?).sort, Role.builtin(true).all.sort
+ assert_equal Role.all.reject(&:builtin?).sort, Role.builtin(false).all.sort
+ end
+
def test_copy_workflows
source = Role.find(1)
assert_equal 90, source.workflows.size
assert_equal 'Non membre', Role.non_member.name
end
+ def test_find_all_givable
+ assert_equal Role.all.reject(&:builtin?).sort, Role.find_all_givable
+ end
+
context "#anonymous" do
should "return the anonymous role" do
role = Role.anonymous