cleanup of tests

diff --git a/tests/lib/appframework/AppTest.php b/tests/lib/appframework/AppTest.php
index e8ae8c8f673bd8f173929f6105c1963fb62343b1..80abaefc43b0a4e285a982facc079b61d6a1e6d5 100644 (file)
--- a/tests/lib/appframework/AppTest.php
+++ b/tests/lib/appframework/AppTest.php
@@ -24,14 +24,6 @@
 
 namespace OC\AppFramework;
 
-use OC\AppFramework\Http\Request;
-use OC\AppFramework\Core\API;
-use OC\AppFramework\Middleware\MiddlewareDispatcher;
-
-// FIXME: loading pimpl correctly from 3rdparty repo
-require_once __DIR__ . '/../../../3rdparty/Pimple/Pimple.php';
-//require_once __DIR__ . "/classloader.php";
-
 
 class AppTest extends \PHPUnit_Framework_TestCase {
 

diff --git a/tests/lib/appframework/middleware/MiddlewareDispatcherTest.php b/tests/lib/appframework/middleware/MiddlewareDispatcherTest.php
index d1b2fedee58878f78f6e22f503a8220142550565..43727846dcf3863af85aa4b14f272d060b805ec6 100644 (file)
--- a/tests/lib/appframework/middleware/MiddlewareDispatcherTest.php
+++ b/tests/lib/appframework/middleware/MiddlewareDispatcherTest.php
@@ -99,6 +99,15 @@ class TestMiddleware extends Middleware {
 
 class MiddlewareDispatcherTest extends \PHPUnit_Framework_TestCase {
 
+       public $exception;
+       public $response;
+       private $out;
+       private $method;
+       private $controller;
+
+       /**
+        * @var MiddlewareDispatcher
+        */
        private $dispatcher;
 
 
@@ -107,7 +116,7 @@ class MiddlewareDispatcherTest extends \PHPUnit_Framework_TestCase {
                $this->controller = $this->getControllerMock();
                $this->method = 'method';
                $this->response = new Response();
-               $this->output = 'hi';
+               $this->out = 'hi';
                $this->exception = new \Exception();
        }
 
@@ -202,11 +211,11 @@ class MiddlewareDispatcherTest extends \PHPUnit_Framework_TestCase {
        public function testBeforeOutputCorrectArguments(){
                $m1 = $this->getMiddleware();
 
-               $this->dispatcher->beforeOutput($this->controller, $this->method, $this->output);
+               $this->dispatcher->beforeOutput($this->controller, $this->method, $this->out);
 
                $this->assertEquals($this->controller, $m1->controller);
                $this->assertEquals($this->method, $m1->methodName);
-               $this->assertEquals($this->output, $m1->output);
+               $this->assertEquals($this->out, $m1->output);
        }
 
 
@@ -248,7 +257,7 @@ class MiddlewareDispatcherTest extends \PHPUnit_Framework_TestCase {
                $m1 = $this->getMiddleware();
                $m2 = $this->getMiddleware();
 
-               $this->dispatcher->beforeOutput($this->controller, $this->method, $this->output);
+               $this->dispatcher->beforeOutput($this->controller, $this->method, $this->out);
 
                $this->assertEquals(2, $m1->beforeOutputOrder);
                $this->assertEquals(1, $m2->beforeOutputOrder);
@@ -268,7 +277,7 @@ class MiddlewareDispatcherTest extends \PHPUnit_Framework_TestCase {
 
                $this->dispatcher->registerMiddleware($m3);
 
-               $this->dispatcher->beforeOutput($this->controller, $this->method, $this->output);
+               $this->dispatcher->beforeOutput($this->controller, $this->method, $this->out);
 
                $this->assertEquals(2, $m1->beforeOutputOrder);
                $this->assertEquals(1, $m2->beforeOutputOrder);