Ignore useless error message "broken pipe" (#30801) (#30842)

Backport #30801 by wxiaoguang

Fix #30792

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

diff --git a/routers/api/packages/maven/maven.go b/routers/api/packages/maven/maven.go
index 27f0578db70e8273a1dfe3c36b44ed1fbb08303c..cb15eae682640e4ff66677eac446fdd9c3d77aae 100644 (file)
--- a/routers/api/packages/maven/maven.go
+++ b/routers/api/packages/maven/maven.go
@@ -140,9 +140,7 @@ func serveMavenMetadata(ctx *context.Context, params parameters) {
        ctx.Resp.Header().Set("Content-Length", strconv.Itoa(len(xmlMetadataWithHeader)))
        ctx.Resp.Header().Set("Content-Type", contentTypeXML)
 
-       if _, err := ctx.Resp.Write(xmlMetadataWithHeader); err != nil {
-               log.Error("write bytes failed: %v", err)
-       }
+       _, _ = ctx.Resp.Write(xmlMetadataWithHeader)
 }
 
 func servePackageFile(ctx *context.Context, params parameters, serveContent bool) {

diff --git a/services/context/base.go b/services/context/base.go
index 62fb743714be3e215019e84ed237e9b8a9e2c929..05b8ab1b9be0b9413f1f4141d558b5c542ad1e21 100644 (file)
--- a/services/context/base.go
+++ b/services/context/base.go
@@ -234,9 +234,7 @@ func (b *Base) plainTextInternal(skip, status int, bs []byte) {
        b.Resp.Header().Set("Content-Type", "text/plain;charset=utf-8")
        b.Resp.Header().Set("X-Content-Type-Options", "nosniff")
        b.Resp.WriteHeader(status)
-       if _, err := b.Resp.Write(bs); err != nil {
-               log.ErrorWithSkip(skip, "plainTextInternal (status=%d): write bytes failed: %v", status, err)
-       }
+       _, _ = b.Resp.Write(bs)
 }
 
 // PlainTextBytes renders bytes as plain text

diff --git a/services/context/context_response.go b/services/context/context_response.go
index d7fd18acacff9de0c16cdd3e82d56125897daa12..87c34c35edebe8f226ef75bb289e4759b84cf260 100644 (file)
--- a/services/context/context_response.go
+++ b/services/context/context_response.go
@@ -13,6 +13,7 @@ import (
        "path"
        "strconv"
        "strings"
+       "syscall"
        "time"
 
        user_model "code.gitea.io/gitea/models/user"
@@ -77,7 +78,7 @@ func (ctx *Context) HTML(status int, name base.TplName) {
        }
 
        err := ctx.Render.HTML(ctx.Resp, status, string(name), ctx.Data, ctx.TemplateContext)
-       if err == nil {
+       if err == nil || errors.Is(err, syscall.EPIPE) {
                return
        }