If .attr() is run on no elements undefined should be returned (as should be the case...

diff --git a/src/core.js b/src/core.js
index 9fa311d506ccef41dc3bd47458fdeccd02452751..ba5d7f5288aa0f753b82bd959afc2d4eb1893625 100644 (file)
--- a/src/core.js
+++ b/src/core.js
@@ -799,7 +799,7 @@ function access( elems, key, value, exec, fn, pass ) {
        }
        
        // Getting an attribute
-       return length ? fn( elems[0], key ) : null;
+       return length ? fn( elems[0], key ) : undefined;
 }
 
 function now() {

diff --git a/test/unit/attributes.js b/test/unit/attributes.js
index 234d586220224675da4a9041a5972949eba439af..c5700adda9d19f414294be4e3d52bc47f1bf3aef 100644 (file)
--- a/test/unit/attributes.js
+++ b/test/unit/attributes.js
@@ -4,7 +4,7 @@ var bareObj = function(value) { return value; };
 var functionReturningObj = function(value) { return (function() { return value; }); };
 
 test("attr(String)", function() {
-       expect(28);
+       expect(30);
 
        // This one sometimes fails randomly ?!
        equals( jQuery('#text1').attr('value'), "Test", 'Check for value attribute' );
@@ -61,6 +61,9 @@ test("attr(String)", function() {
        select.appendChild( optgroup );
 
        equals( jQuery(option).attr("selected"), true, "Make sure that a single option is selected, even when in an optgroup." );
+
+       ok( jQuery("<div/>").attr("doesntexist") === undefined, "Make sure undefined is returned when no attribute is found." );
+       ok( jQuery().attr("doesntexist") === undefined, "Make sure undefined is returned when no element is there." );
 });
 
 if ( !isLocal ) {