Build: Require strict mode in Node.js scripts via ESLint

So far, only browser-based JS files were required to be in strict mode (in the
function form). This commit adds such a requirement to Node.js scripts where
the global form is preferred. All Node.js scripts in sloppy mode were
converted to strict mode.

Closes gh-4499

(cherry picked from commit bbad821c399da92995a11b88d6684970479d4a9b)

diff --git a/.eslintrc-node.json b/.eslintrc-node.json
index 589144272ce4e865005369ea487d3c16ef3c9465..544a92cdc8a9cd2c3a141e8c0167b48f8dad7d2a 100644 (file)
--- a/.eslintrc-node.json
+++ b/.eslintrc-node.json
@@ -10,5 +10,9 @@
        "env": {
                "es6": true,
                "node": true
+       },
+
+       "rules": {
+               "strict": ["error", "global"]
        }
 }

diff --git a/Gruntfile.js b/Gruntfile.js
index 9524e70c0bcd10af27c13db5eab0f1215a0d5b39..8458a6772b03ec1fc514719a5dfa39584687d901 100644 (file)
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -1,6 +1,6 @@
-module.exports = function( grunt ) {
-       "use strict";
+"use strict";
 
+module.exports = function( grunt ) {
        function readOptionalJSON( filepath ) {
                var stripJSONComments = require( "strip-json-comments" ),
                        data = {};

diff --git a/build/release.js b/build/release.js
index a3b5fc2ba0eeb698fe5ab551504348d114163215..a9713fc087e7fcdc0b526b75bfe991961c8f8a55 100644 (file)
--- a/build/release.js
+++ b/build/release.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var fs = require( "fs" );
 
 module.exports = function( Release ) {

diff --git a/build/release/cdn.js b/build/release/cdn.js
index c65c53e8caa5507965dd1941df344469a947cb5e..3d96d01791833f550cac2b5aae10ba731e2487d8 100644 (file)
--- a/build/release/cdn.js
+++ b/build/release/cdn.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var
        fs = require( "fs" ),
        shell = require( "shelljs" ),

diff --git a/build/release/dist.js b/build/release/dist.js
index ef4ee7c923f2549db694a5fe8715e4fd37a14b79..9120aa2ac29acc8a5cc58aa40d1efe92a053932c 100644 (file)
--- a/build/release/dist.js
+++ b/build/release/dist.js
@@ -1,3 +1,5 @@
+"use strict";
+
 module.exports = function( Release, files, complete ) {
 
        var

diff --git a/build/release/ensure-sizzle.js b/build/release/ensure-sizzle.js
index f9c5c70dd1d9fc053448497d403643cb55321355..eb1cbd8e80d1624ecbff2aa8828df1814e94e273 100644 (file)
--- a/build/release/ensure-sizzle.js
+++ b/build/release/ensure-sizzle.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var fs = require( "fs" ),
        npm = require( "npm" ),
        chalk = require( "chalk" ),

diff --git a/build/tasks/build.js b/build/tasks/build.js
index 73dfd581d146c5253e679f3036432d823c0288e4..1a6e5d02a14a600c1f679d254d9e1fbbfe7167fc 100644 (file)
--- a/build/tasks/build.js
+++ b/build/tasks/build.js
@@ -4,10 +4,9 @@
  * and includes/excludes specified modules
  */
 
-module.exports = function( grunt ) {
-
-       "use strict";
+"use strict";
 
+module.exports = function( grunt ) {
        var fs = require( "fs" ),
                requirejs = require( "requirejs" ),
                Insight = require( "insight" ),

diff --git a/build/tasks/dist.js b/build/tasks/dist.js
index fa6920c88949afd3dbeb43d3cea5e1b99a506b97..f19929b896886838e1e6fecf5d0fbf6c7d08e1d9 100644 (file)
--- a/build/tasks/dist.js
+++ b/build/tasks/dist.js
@@ -1,7 +1,6 @@
-module.exports = function( grunt ) {
-
-       "use strict";
+"use strict";
 
+module.exports = function( grunt ) {
        var     fs = require( "fs" ),
                filename = grunt.option( "filename" ),
                distpaths = [

diff --git a/build/tasks/node_smoke_tests.js b/build/tasks/node_smoke_tests.js
index e3d69db883a472b2106bca6586fa9719ce662577..40c49a4d98a83a404da180d84f230ca7fcdc7890 100644 (file)
--- a/build/tasks/node_smoke_tests.js
+++ b/build/tasks/node_smoke_tests.js
@@ -1,7 +1,6 @@
-module.exports = ( grunt ) => {
-
-       "use strict";
+"use strict";
 
+module.exports = ( grunt ) => {
        const fs = require( "fs" );
        const spawnTest = require( "./lib/spawn_test.js" );
        const testsDir = "./test/node_smoke_tests/";

diff --git a/build/tasks/qunit_fixture.js b/build/tasks/qunit_fixture.js
index 3f332dad03b288912c4311011d3f15984dfa978f..138ca662ddb7929065c22f4e2c8abde11f53c118 100644 (file)
--- a/build/tasks/qunit_fixture.js
+++ b/build/tasks/qunit_fixture.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var fs = require( "fs" );
 
 module.exports = function( grunt ) {

diff --git a/build/tasks/sourcemap.js b/build/tasks/sourcemap.js
index 3f21b2afd07b1aebe39ae00051151c19a05b2e5c..509374f2ee4e26a8697607b3d48b10c92dc464c3 100644 (file)
--- a/build/tasks/sourcemap.js
+++ b/build/tasks/sourcemap.js
@@ -1,3 +1,5 @@
+"use strict";
+
 var fs = require( "fs" );
 
 module.exports = function( grunt ) {

diff --git a/build/tasks/testswarm.js b/build/tasks/testswarm.js
index 88e883d0f956b0c80df4ec1ece3f57e15b16b42d..d2653e0e057d2fab5247145db029275fd87d0c5a 100644 (file)
--- a/build/tasks/testswarm.js
+++ b/build/tasks/testswarm.js
@@ -1,7 +1,6 @@
-module.exports = function( grunt ) {
-
-       "use strict";
+"use strict";
 
+module.exports = function( grunt ) {
        grunt.registerTask( "testswarm", function( commit, configFile, projectName, browserSets,
                        timeout, testMode ) {
                var jobName, config, tests,