Fix quality flaws

diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/config/PropertyDefinition.java b/sonar-plugin-api/src/main/java/org/sonar/api/config/PropertyDefinition.java
index 038c7182c2064fd01d7b996ccc47f3e78601db25..2bd49827409fe55cb7cdec16b63c963d5c7f2775 100644 (file)
--- a/sonar-plugin-api/src/main/java/org/sonar/api/config/PropertyDefinition.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/config/PropertyDefinition.java
@@ -157,21 +157,21 @@ public final class PropertyDefinition implements BatchExtension, ServerExtension
     return Result.SUCCESS;
   }
 
-  private static Result validateBoolean(@Nullable String value) {
+  private static Result validateBoolean(String value) {
     if (!StringUtils.equalsIgnoreCase(value, "true") && !StringUtils.equalsIgnoreCase(value, "false")) {
       return Result.newError("notBoolean");
     }
     return Result.SUCCESS;
   }
 
-  private static Result validateInteger(@Nullable String value) {
+  private static Result validateInteger(String value) {
     if (!NumberUtils.isDigits(value)) {
       return Result.newError("notInteger");
     }
     return Result.SUCCESS;
   }
 
-  private static Result validateFloat(@Nullable String value) {
+  private static Result validateFloat(String value) {
     try {
       Double.parseDouble(value);
       return Result.SUCCESS;

diff --git a/sonar-server/src/main/java/org/sonar/server/issue/InternalRubyIssueService.java b/sonar-server/src/main/java/org/sonar/server/issue/InternalRubyIssueService.java
index 702da148d3df050d8ab5c43c218f24dfaea47159..7d657d98751a28bb89190dc66956cb07e0f5b95d 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/issue/InternalRubyIssueService.java
+++ b/sonar-server/src/main/java/org/sonar/server/issue/InternalRubyIssueService.java
@@ -62,9 +62,9 @@ import java.util.Map;
  */
 public class InternalRubyIssueService implements ServerComponent {
 
-  private final static String ID_PARAM = "id";
-  private final static String NAME_PARAM = "name";
-  private final static String DESCRIPTION_PARAM = "description";
+  private static final String ID_PARAM = "id";
+  private static final String NAME_PARAM = "name";
+  private static final String DESCRIPTION_PARAM = "description";
 
   private final IssueService issueService;
   private final IssueCommentService commentService;