]> source.dussan.org Git - jquery-ui.git/commitdiff
projects / jquery-ui.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 969d182)
Core: Make back compat disabled by default
authorMichał Gołębiowski-Owczarek <m.goleb@gmail.com>
Mon, 13 May 2024 16:11:57 +0000 (18:11 +0200)
committerGitHub <noreply@github.com>
Mon, 13 May 2024 16:11:57 +0000 (18:11 +0200)
Closes gh-2250

15 files changed:
tests/lib/bootstrap.js patch | blob | history
tests/unit/button/button.html patch | blob | history
tests/unit/dialog/dialog.html patch | blob | history
tests/unit/droppable/droppable.html patch | blob | history
tests/unit/tabs/core.js patch | blob | history
tests/unit/tooltip/tooltip.html patch | blob | history
ui/effect.js patch | blob | history
ui/effects/effect-transfer.js patch | blob | history
ui/widgets/button.js patch | blob | history
ui/widgets/dialog.js patch | blob | history
ui/widgets/droppable.js patch | blob | history
ui/widgets/resizable.js patch | blob | history
ui/widgets/spinner.js patch | blob | history
ui/widgets/tabs.js patch | blob | history
ui/widgets/tooltip.js patch | blob | history

diff --git a/tests/lib/bootstrap.js b/tests/lib/bootstrap.js
index fd9b1eb654bd19a5edfc78767f320cae770b8500..e0df9ebf5da5d86564ec6fe85072ff2febf9bdef 100644 (file)
--- a/tests/lib/bootstrap.js
+++ b/tests/lib/bootstrap.js
@@ -25,9 +25,9 @@ requirejs.config( {
        }
 } );
 
-// Create a module that disables back compat for UI modules
-define( "jquery-no-back-compat", [ "jquery" ], function( $ ) {
-       $.uiBackCompat = false;
+// Create a module that enables back compat for UI modules
+define( "jquery-back-compat", [ "jquery" ], function( $ ) {
+       $.uiBackCompat = true;
 
        return $;
 } );
@@ -53,10 +53,12 @@ function requireModules( dependencies, callback, modules ) {
 }
 
 // Load a set of test file along with the required test infrastructure
-function requireTests( dependencies, noBackCompat ) {
-       var preDependencies = [
+function requireTests( dependencies, options ) {
+
+       var backCompat = !!( options && options.backCompat ),
+               preDependencies = [
                "lib/qunit",
-               noBackCompat ? "jquery-no-back-compat" : "jquery",
+               backCompat ? "jquery-back-compat" : "jquery",
                "jquery-simulate"
        ];
 
@@ -136,7 +138,7 @@ function migrateUrl() {
 // - data-widget: A widget to load test modules for
 //   - Automatically loads common, core, events, methods, and options
 // - data-deprecated: Loads the deprecated test modules for a widget
-// - data-no-back-compat: Set $.uiBackCompat to false
+// - data-back-compat: Set $.uiBackCompat to `true`
 ( function() {
 
        // Find the script element
@@ -154,7 +156,7 @@ function migrateUrl() {
        }
        var widget = script.getAttribute( "data-widget" );
        var deprecated = !!script.getAttribute( "data-deprecated" );
-       var noBackCompat = !!script.getAttribute( "data-no-back-compat" );
+       var backCompat = !!script.getAttribute( "data-back-compat" );
 
        if ( widget ) {
                modules = modules.concat( [
@@ -177,7 +179,7 @@ function migrateUrl() {
                modules.unshift( "ui/jquery-patch" );
        }
 
-       requireTests( modules, noBackCompat );
+       requireTests( modules, { backCompat: backCompat } );
 } )();
 
 } )();
diff --git a/tests/unit/button/button.html b/tests/unit/button/button.html
index 6cf27fb33eac6f71665b8a3be41a4980a3c1585d..1c3d10199f0a50496d72e33aea832f72183db74c 100644 (file)
--- a/tests/unit/button/button.html
+++ b/tests/unit/button/button.html
@@ -6,7 +6,7 @@
 
        <script src="../../../external/requirejs/require.js"></script>
        <script src="../../lib/css.js" data-modules="core button"></script>
-       <script src="../../lib/bootstrap.js" data-widget="button" data-no-back-compat="true"></script>
+       <script src="../../lib/bootstrap.js" data-widget="button"></script>
 </head>
 <body>
 
diff --git a/tests/unit/dialog/dialog.html b/tests/unit/dialog/dialog.html
index bdba5e11cb62f06488fa917b18839e95601270e1..30f22c60e2115afe25202015c704c9e238af270d 100644 (file)
--- a/tests/unit/dialog/dialog.html
+++ b/tests/unit/dialog/dialog.html
@@ -6,7 +6,7 @@
 
        <script src="../../../external/requirejs/require.js"></script>
        <script src="../../lib/css.js" data-modules="core button dialog"></script>
-       <script src="../../lib/bootstrap.js" data-widget="dialog" data-no-back-compat="true"></script>
+       <script src="../../lib/bootstrap.js" data-widget="dialog"></script>
 </head>
 <body>
 
diff --git a/tests/unit/droppable/droppable.html b/tests/unit/droppable/droppable.html
index 5c3ec3dd90a546e0a0f47177ac874ca4c7fa80fb..e507bb56153025656cd6c186e78f6935fa2816b5 100644 (file)
--- a/tests/unit/droppable/droppable.html
+++ b/tests/unit/droppable/droppable.html
@@ -6,8 +6,7 @@
 
        <script src="../../../external/requirejs/require.js"></script>
        <script src="../../lib/css.js" data-modules="core"></script>
-       <script src="../../lib/bootstrap.js" data-widget="droppable"
-               data-no-back-compat="true"></script>
+       <script src="../../lib/bootstrap.js" data-widget="droppable"></script>
 </head>
 <body>
 
diff --git a/tests/unit/tabs/core.js b/tests/unit/tabs/core.js
index 7637cfb1fd92387fb53f2b83aeb44da918d5b84f..0f9e7acbb3bf4780a6769bb5e207415c51633cf3 100644 (file)
--- a/tests/unit/tabs/core.js
+++ b/tests/unit/tabs/core.js
@@ -29,9 +29,9 @@ QUnit.test( "markup structure", function( assert ) {
        assert.hasClasses( tabs[ 2 ], "ui-tabs-tab" );
 
        // DEPRECATED
-       assert.hasClasses( tabs[ 0 ], "ui-tab" );
-       assert.hasClasses( tabs[ 1 ], "ui-tab" );
-       assert.hasClasses( tabs[ 2 ], "ui-tab" );
+       assert.lacksClasses( tabs[ 0 ], "ui-tab" );
+       assert.lacksClasses( tabs[ 1 ], "ui-tab" );
+       assert.lacksClasses( tabs[ 2 ], "ui-tab" );
 
        assert.equal( tabs.length, 3, "There are exactly three tabs" );
        assert.hasClasses( anchors[ 0 ], "ui-tabs-anchor" );
diff --git a/tests/unit/tooltip/tooltip.html b/tests/unit/tooltip/tooltip.html
index b5561d926105c906c42e176f361265d9563863d1..8c6dec70d0282640f67e5ae11d4b3897eb20f232 100644 (file)
--- a/tests/unit/tooltip/tooltip.html
+++ b/tests/unit/tooltip/tooltip.html
@@ -6,7 +6,7 @@
 
        <script src="../../../external/requirejs/require.js"></script>
        <script src="../../lib/css.js" data-modules="core tooltip"></script>
-       <script src="../../lib/bootstrap.js" data-widget="tooltip" data-no-back-compat="true"></script>
+       <script src="../../lib/bootstrap.js" data-widget="tooltip"></script>
 </head>
 <body>
 
diff --git a/ui/effect.js b/ui/effect.js
index 10cf8ed609acdc40d9a392b1b076dac01d92f294..2232e041d86387d4b85f384f8ecfacac14ccb08e 100644 (file)
--- a/ui/effect.js
+++ b/ui/effect.js
@@ -273,7 +273,7 @@ if ( $.expr && $.expr.pseudos && $.expr.pseudos.animated ) {
        } )( $.expr.pseudos.animated );
 }
 
-if ( $.uiBackCompat !== false ) {
+if ( $.uiBackCompat === true ) {
        $.extend( $.effects, {
 
                // Saves a set of properties in a data storage
@@ -759,7 +759,7 @@ $.fn.extend( {
                        // as toggle can be either show or hide depending on element state
                        args.mode = modes.shift();
 
-                       if ( $.uiBackCompat !== false && !defaultMode ) {
+                       if ( $.uiBackCompat === true && !defaultMode ) {
                                if ( elem.is( ":hidden" ) ? mode === "hide" : mode === "show" ) {
 
                                        // Call the core method to track "olddisplay" properly
diff --git a/ui/effects/effect-transfer.js b/ui/effects/effect-transfer.js
index 2014dba37b991e9078bc9276ea41d2bc0a3d52cb..132ccc1c2a30c7041a1743ade2bad35506b45e68 100644 (file)
--- a/ui/effects/effect-transfer.js
+++ b/ui/effects/effect-transfer.js
@@ -33,7 +33,7 @@
 "use strict";
 
 var effect;
-if ( $.uiBackCompat !== false ) {
+if ( $.uiBackCompat === true ) {
        effect = $.effects.define( "transfer", function( options, done ) {
                $( this ).transfer( options, done );
        } );
diff --git a/ui/widgets/button.js b/ui/widgets/button.js
index c127a6d009a1f349ec3120a71839a99c79b259fa..02708d620c262de2602a8e0a557237c4912e331a 100644 (file)
--- a/ui/widgets/button.js
+++ b/ui/widgets/button.js
@@ -287,7 +287,7 @@ $.widget( "ui.button", {
 } );
 
 // DEPRECATED
-if ( $.uiBackCompat !== false ) {
+if ( $.uiBackCompat === true ) {
 
        // Text and Icons options
        $.widget( "ui.button", $.ui.button, {
diff --git a/ui/widgets/dialog.js b/ui/widgets/dialog.js
index 02f63d7282f648f75174abc97c4c4fc7adb5aa80..e04598dccd7dbf255df21c5aae9ebec17bfb29af 100644 (file)
--- a/ui/widgets/dialog.js
+++ b/ui/widgets/dialog.js
@@ -930,7 +930,7 @@ $.widget( "ui.dialog", {
 
 // DEPRECATED
 // TODO: switch return back to widget declaration at top of file when this is removed
-if ( $.uiBackCompat !== false ) {
+if ( $.uiBackCompat === true ) {
 
        // Backcompat for dialogClass option
        $.widget( "ui.dialog", $.ui.dialog, {
diff --git a/ui/widgets/droppable.js b/ui/widgets/droppable.js
index 45fca0560a1c14fdbf68ee070d7b3f75ca8390ed..1ff3833ba9d56d41622d56921d8609a3d85617e9 100644 (file)
--- a/ui/widgets/droppable.js
+++ b/ui/widgets/droppable.js
@@ -463,7 +463,7 @@ $.ui.ddmanager = {
 
 // DEPRECATED
 // TODO: switch return back to widget declaration at top of file when this is removed
-if ( $.uiBackCompat !== false ) {
+if ( $.uiBackCompat === true ) {
 
        // Backcompat for activeClass and hoverClass options
        $.widget( "ui.droppable", $.ui.droppable, {
diff --git a/ui/widgets/resizable.js b/ui/widgets/resizable.js
index 7be097e73fecaa5f1b6edf3ae5bfdea16b1de47c..e163b03fead43935ff2193d5a630281e8856816a 100644 (file)
--- a/ui/widgets/resizable.js
+++ b/ui/widgets/resizable.js
@@ -1113,7 +1113,7 @@ $.ui.plugin.add( "resizable", "ghost", {
 
                // DEPRECATED
                // TODO: remove after 1.12
-               if ( $.uiBackCompat !== false && typeof that.options.ghost === "string" ) {
+               if ( $.uiBackCompat === true && typeof that.options.ghost === "string" ) {
 
                        // Ghost option
                        that.ghost.addClass( this.options.ghost );
diff --git a/ui/widgets/spinner.js b/ui/widgets/spinner.js
index c35929a01c59d6d34b0eb25e3bbc451e7e4ccb57..b92b8ab520be0af8a0016c1dd51ffbf3390f703a 100644 (file)
--- a/ui/widgets/spinner.js
+++ b/ui/widgets/spinner.js
@@ -554,7 +554,7 @@ $.widget( "ui.spinner", {
 
 // DEPRECATED
 // TODO: switch return back to widget declaration at top of file when this is removed
-if ( $.uiBackCompat !== false ) {
+if ( $.uiBackCompat === true ) {
 
        // Backcompat for spinner html extension points
        $.widget( "ui.spinner", $.ui.spinner, {
diff --git a/ui/widgets/tabs.js b/ui/widgets/tabs.js
index b8373c4e93b7f411677fb211bd992a77ac228df8..be4fe7e7a8e930bfcd9782953b60e217010ce7d7 100644 (file)
--- a/ui/widgets/tabs.js
+++ b/ui/widgets/tabs.js
@@ -909,7 +909,7 @@ $.widget( "ui.tabs", {
 
 // DEPRECATED
 // TODO: Switch return back to widget declaration at top of file when this is removed
-if ( $.uiBackCompat !== false ) {
+if ( $.uiBackCompat === true ) {
 
        // Backcompat for ui-tab class (now ui-tabs-tab)
        $.widget( "ui.tabs", $.ui.tabs, {
diff --git a/ui/widgets/tooltip.js b/ui/widgets/tooltip.js
index 083c0389e4d0028a4b59ae1cdfce387707517976..b626c5d1016ebcd16db55eead228f1929e642575 100644 (file)
--- a/ui/widgets/tooltip.js
+++ b/ui/widgets/tooltip.js
@@ -505,7 +505,7 @@ $.widget( "ui.tooltip", {
 
 // DEPRECATED
 // TODO: Switch return back to widget declaration at top of file when this is removed
-if ( $.uiBackCompat !== false ) {
+if ( $.uiBackCompat === true ) {
 
        // Backcompat for tooltipClass option
        $.widget( "ui.tooltip", $.ui.tooltip, {
The official jQuery user interface library: https://github.com/jquery/jquery-ui