]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-3755 remove unused methods in issue ws client
authorSimon Brandhof <simon.brandhof@gmail.com>
Fri, 17 May 2013 18:02:40 +0000 (20:02 +0200)
committerSimon Brandhof <simon.brandhof@gmail.com>
Fri, 17 May 2013 18:02:40 +0000 (20:02 +0200)
sonar-ws-client/src/main/java/org/sonar/wsclient/issue/Issue.java
sonar-ws-client/src/main/java/org/sonar/wsclient/issue/IssueQuery.java
sonar-ws-client/src/test/java/org/sonar/wsclient/issue/IssueParserTest.java

index 69cab8fc29cebae70e3604b0c4e4126cb5c89b89..c00f4d25f0e716d809a7188b9737a4e8dece3d45 100644 (file)
@@ -54,14 +54,6 @@ public class Issue {
     return JsonUtils.getString(json, "severity");
   }
 
-  /**
-   * TODO to be removed
-   */
-  @CheckForNull
-  public String description() {
-    return JsonUtils.getString(json, "message");
-  }
-
   @CheckForNull
   public String message() {
     return JsonUtils.getString(json, "message");
@@ -89,15 +81,6 @@ public class Issue {
     return JsonUtils.getString(json, "resolution");
   }
 
-  /**
-   * Login of the user who created the manual issue, else null.
-   * TODO to be removed
-   */
-  @CheckForNull
-  public String userLogin() {
-    return JsonUtils.getString(json, "reporter");
-  }
-
   @CheckForNull
   public String reporter() {
     return JsonUtils.getString(json, "reporter");
index 204e90c6f5426bb6f60ec5337b033746f93a2b1f..db597021e088c2de8461e4ce3dfcbffe86bd3025 100644 (file)
@@ -76,13 +76,6 @@ public class IssueQuery {
     return addParam("actionPlans", s);
   }
 
-  /**
-   * TODO To be removed
-   */
-  public IssueQuery userLogins(String... s) {
-    return addParam("reporters", s);
-  }
-
   public IssueQuery reporters(String... s) {
     return addParam("reporters", s);
   }
index 2b2cb50984bbbf3a05ca9a8fbd5d3c788cbad740..1d84ad11cbc1f86e74a7b41cbed3a7f4334efe5d 100644 (file)
@@ -47,7 +47,7 @@ public class IssueParserTest {
     assertThat(first.assignee()).isEqualTo("karadoc");
     assertThat(first.message()).isEqualTo("the message");
     assertThat(first.effortToFix()).isEqualTo(4.2);
-    assertThat(first.userLogin()).isEqualTo("perceval");
+    assertThat(first.reporter()).isEqualTo("perceval");
     assertThat(first.creationDate()).isNotNull();
     assertThat(first.updateDate()).isNotNull();
     assertThat(first.closeDate()).isNotNull();
@@ -60,7 +60,7 @@ public class IssueParserTest {
     assertThat(second.key()).isEqualTo("FGHIJ");
     assertThat(second.line()).isNull();
     assertThat(second.effortToFix()).isNull();
-    assertThat(second.description()).isNull();
+    assertThat(second.reporter()).isNull();
     assertThat(second.attribute("JIRA")).isNull();
     assertThat(second.attributes()).isEmpty();
     assertThat(second.comments()).isEmpty();