SONAR-15440 SONAR-15441 Remove internal flag for Quality Gate permission management...

diff --git a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddGroupActionIT.java b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddGroupActionIT.java
index 6b96277d189863e3f96eebf6e6384b1650886699..838bf13b26d28867a9631a058056a7e3dea798a2 100644 (file)
--- a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddGroupActionIT.java
+++ b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddGroupActionIT.java
@@ -63,7 +63,6 @@ public class AddGroupActionIT {
     WebService.Action def = ws.getDef();
     assertThat(def.key()).isEqualTo("add_group");
     assertThat(def.isPost()).isTrue();
-    assertThat(def.isInternal()).isTrue();
     assertThat(def.params()).extracting(WebService.Param::key).containsExactlyInAnyOrder("groupName", "gateName");
   }
 

diff --git a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddUserActionIT.java b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddUserActionIT.java
index b9b63c51cd603e55e4f0999cf173d87f06e716dc..55f53c200ea08cf7564efb4414aaf2f0fdc4221b 100644 (file)
--- a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddUserActionIT.java
+++ b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddUserActionIT.java
@@ -59,7 +59,6 @@ public class AddUserActionIT {
     WebService.Action def = ws.getDef();
     assertThat(def.key()).isEqualTo("add_user");
     assertThat(def.isPost()).isTrue();
-    assertThat(def.isInternal()).isTrue();
     assertThat(def.params()).extracting(WebService.Param::key).containsExactlyInAnyOrder("login", "gateName");
   }
 

diff --git a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveGroupActionIT.java b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveGroupActionIT.java
index 6d6c0b32bab0ff37820aea5cbf600e28970e9486..8ab0a2438cfc1eeeb7bdd35efdf00f51f8237b22 100644 (file)
--- a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveGroupActionIT.java
+++ b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveGroupActionIT.java
@@ -56,7 +56,6 @@ public class RemoveGroupActionIT {
     WebService.Action def = ws.getDef();
     assertThat(def.key()).isEqualTo("remove_group");
     assertThat(def.isPost()).isTrue();
-    assertThat(def.isInternal()).isTrue();
     assertThat(def.params()).extracting(WebService.Param::key).containsExactlyInAnyOrder("groupName", "gateName");
   }
 

diff --git a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveUserActionIT.java b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveUserActionIT.java
index b9ddfa2c8ad09e442f31ba2ee04187e0bf0d92e1..e1ea8f01a8049f7aba90a0359b6bd9e9f2743013 100644 (file)
--- a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveUserActionIT.java
+++ b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveUserActionIT.java
@@ -56,7 +56,6 @@ public class RemoveUserActionIT {
     WebService.Action def = ws.getDef();
     assertThat(def.key()).isEqualTo("remove_user");
     assertThat(def.isPost()).isTrue();
-    assertThat(def.isInternal()).isTrue();
     assertThat(def.params()).extracting(WebService.Param::key).containsExactlyInAnyOrder("login", "gateName");
   }
 

diff --git a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchGroupsActionIT.java b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchGroupsActionIT.java
index 2227ebbad1d09e7a99b4cd0413124e1350652f68..ed3491cb6a069f183f77c6eaa795ee1fc67267b6 100644 (file)
--- a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchGroupsActionIT.java
+++ b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchGroupsActionIT.java
@@ -64,7 +64,6 @@ public class SearchGroupsActionIT {
     WebService.Action def = ws.getDef();
     assertThat(def.key()).isEqualTo("search_groups");
     assertThat(def.isPost()).isFalse();
-    assertThat(def.isInternal()).isTrue();
     assertThat(def.params()).extracting(WebService.Param::key)
       .containsExactlyInAnyOrder("gateName", "selected", "q", "p", "ps");
   }

diff --git a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchUsersActionIT.java b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchUsersActionIT.java
index ced09386a53891b46efb61348b4052c9b3f6cedd..b42f0f7339856504de3b36af726d987bd29fd384 100644 (file)
--- a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchUsersActionIT.java
+++ b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchUsersActionIT.java
@@ -64,7 +64,6 @@ public class SearchUsersActionIT {
     WebService.Action def = ws.getDef();
     assertThat(def.key()).isEqualTo("search_users");
     assertThat(def.isPost()).isFalse();
-    assertThat(def.isInternal()).isTrue();
     assertThat(def.params()).extracting(WebService.Param::key)
       .containsExactlyInAnyOrder("gateName", "selected", "q", "p", "ps");
   }

diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddGroupAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddGroupAction.java
index b36fe28f29c309b4ad4d8ae131587a6d1b08724b..09977a698fc9adf5f9c4ffe3195d30219c9343ee 100644 (file)
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddGroupAction.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddGroupAction.java
@@ -49,7 +49,6 @@ public class AddGroupAction extends AbstractGroupAction {
         "</ul>")
       .setHandler(this)
       .setPost(true)
-      .setInternal(true)
       .setSince("9.2");
 
     super.defineGateAndGroupParameters(action);

diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddUserAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddUserAction.java
index e6c815ae0e8cb5000cbc70d29f229aa04c0d16ba..563d946a14eb6227dc377599166f254267885f65 100644 (file)
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddUserAction.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddUserAction.java
@@ -50,7 +50,6 @@ public class AddUserAction extends AbstractUserAction {
         "</ul>")
       .setHandler(this)
       .setPost(true)
-      .setInternal(true)
       .setSince("9.2");
 
     super.defineGateAndUserParameters(action);

diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveGroupAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveGroupAction.java
index a495428b6a12e1076e9867fc2d2329b8ed323d9e..3aa0eba9e6420445e97455fde14990ee0fe65c4f 100644 (file)
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveGroupAction.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveGroupAction.java
@@ -45,7 +45,6 @@ public class RemoveGroupAction extends AbstractGroupAction {
         "</ul>")
       .setHandler(this)
       .setPost(true)
-      .setInternal(true)
       .setSince("9.2");
 
     super.defineGateAndGroupParameters(action);

diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveUserAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveUserAction.java
index 083d1a63d303f85092e9d2df5f0e0be3c35048e7..fdbcfcd38699b1e17ce0e1d8159badad5c5168b0 100644 (file)
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveUserAction.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveUserAction.java
@@ -45,7 +45,6 @@ public class RemoveUserAction extends AbstractUserAction {
         "</ul>")
       .setHandler(this)
       .setPost(true)
-      .setInternal(true)
       .setSince("9.2");
 
     super.defineGateAndUserParameters(action);

diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchGroupsAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchGroupsAction.java
index 314446b9466f1078f03ce02f46c8de071cc6014d..e8478ede9e9f5d17eae647c666d49acf8d5fcdb9 100644 (file)
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchGroupsAction.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchGroupsAction.java
@@ -75,7 +75,6 @@ public class SearchGroupsAction implements QualityGatesWsAction {
         "  <li>Edit right on the specified quality gate</li>" +
         "</ul>")
       .setHandler(this)
-      .setInternal(true)
       .addSelectionModeParam()
       .addSearchQuery("sonar", "group names")
       .addPagingParams(25)

diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchUsersAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchUsersAction.java
index 1e81fe02336cf81a40063bc2c9413369a25781ea..baaf7177278a9cc15d9ee7e63a24c13cc0bd410a 100644 (file)
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchUsersAction.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchUsersAction.java
@@ -80,7 +80,6 @@ public class SearchUsersAction implements QualityGatesWsAction {
         "  <li>Edit right on the specified quality gate</li>" +
         "</ul>")
       .setHandler(this)
-      .setInternal(true)
       .addSearchQuery("freddy", "names", "logins")
       .addSelectionModeParam()
       .addPagingParams(25)