Check if array elements exist before using them

It seems that in some recent upgrade here. Not always the entries we
expect are returned. So we should first check if they exist. As to not
spam the log.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

diff --git a/apps/files_external/lib/Lib/Storage/AmazonS3.php b/apps/files_external/lib/Lib/Storage/AmazonS3.php
index 4510de8b6ec2a48db4adcd9ca366dc9ebd01ba67..3cdff1d6f40e5f21c13ddeb573412ff9be3cabe0 100644 (file)
--- a/apps/files_external/lib/Lib/Storage/AmazonS3.php
+++ b/apps/files_external/lib/Lib/Storage/AmazonS3.php
@@ -165,7 +165,13 @@ class AmazonS3 extends \OC\Files\Storage\Common {
                                        'MaxKeys' => 1,
                                        'Delimiter' => '/',
                                ]);
-                               $this->directoryCache[$path] = ($result['Contents'][0]['Key'] === rtrim($path, '/') . '/') || $result['CommonPrefixes'];
+
+                               if ((isset($result['Contents'][0]['Key']) && $result['Contents'][0]['Key'] === rtrim($path, '/') . '/')
+                                        || isset($result['CommonPrefixes'])) {
+                                       $this->directoryCache[$path] = true;
+                               } else {
+                                       $this->directoryCache[$path] = false;
+                               }
                        } catch (S3Exception $e) {
                                if ($e->getStatusCode() === 403) {
                                        $this->directoryCache[$path] = false;