]> source.dussan.org Git - sonarqube.git/commitdiff
fix display of links from QG failures
authorStas Vilchik <vilchiks@gmail.com>
Thu, 19 May 2016 16:04:49 +0000 (18:04 +0200)
committerStas Vilchik <vilchiks@gmail.com>
Thu, 19 May 2016 16:04:49 +0000 (18:04 +0200)
server/sonar-web/src/main/js/apps/overview/qualityGate/QualityGateCondition.js
server/sonar-web/tests/apps/overview/qualityGate/QualityGateCondition-test.js [new file with mode: 0644]

index 7708f2f90a8845d3a5e67a138218bd586004f05d..2910c3d81c3428a1d6ce01592cf3e15d9ac6ff0f 100644 (file)
@@ -51,7 +51,7 @@ const QualityGateCondition = ({ component, periods, condition }) => {
           <div className="overview-quality-gate-condition-value">
             <DrilldownLink
                 component={component.key}
-                metric={metric.name}
+                metric={metric.key}
                 period={condition.period}
                 periodDate={periodDate}>
               <span className={'alert_' + condition.level.toUpperCase()}>
diff --git a/server/sonar-web/tests/apps/overview/qualityGate/QualityGateCondition-test.js b/server/sonar-web/tests/apps/overview/qualityGate/QualityGateCondition-test.js
new file mode 100644 (file)
index 0000000..3f0e924
--- /dev/null
@@ -0,0 +1,61 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2016 SonarSource SA
+ * mailto:contact AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+import React from 'react';
+import { expect } from 'chai';
+import { shallow } from 'enzyme';
+
+import QualityGateCondition from '../../../../src/main/js/apps/overview/qualityGate/QualityGateCondition';
+import { DrilldownLink } from '../../../../src/main/js/components/shared/drilldown-link';
+
+describe('Overview :: QualityGateCondition', () => {
+  it('should render DrilldownLink', () => {
+    const component = {
+      id: 'abcd',
+      key: 'abcd-key'
+    };
+    const periods = [];
+    const condition = {
+      actual: '10',
+      error: '0',
+      level: 'ERROR',
+      measure: {
+        metric: {
+          key: 'open_issues',
+          type: 'INT',
+          name: 'Open Issues'
+        },
+        value: '10'
+      },
+      metric: 'open_issues',
+      op: 'GT'
+    };
+
+    const output = shallow(
+        <QualityGateCondition
+            component={component}
+            periods={periods}
+            condition={condition}/>
+    );
+
+    const link = output.find(DrilldownLink);
+    expect(link.prop('component')).to.equal('abcd-key');
+    expect(link.prop('metric')).to.equal('open_issues');
+  });
+});