*/
package org.sonar.batch.bootstrap;
+import org.apache.commons.lang.StringUtils;
+
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-
import org.sonar.api.CoreProperties;
import java.text.MessageFormat;
preview = "true".equals(props.property(CoreProperties.DRY_RUN));
} else {
String mode = props.property(CoreProperties.ANALYSIS_MODE);
+ validate(mode);
preview = CoreProperties.ANALYSIS_MODE_PREVIEW.equals(mode) || CoreProperties.ANALYSIS_MODE_QUICK.equals(mode);
}
LOG.info("Preview global mode");
}
}
+
+ private void validate(String mode) {
+ if (StringUtils.isEmpty(mode)) {
+ return;
+ }
+
+ if (!CoreProperties.ANALYSIS_MODE_PREVIEW.equals(mode) && !CoreProperties.ANALYSIS_MODE_QUICK.equals(mode) &&
+ !CoreProperties.ANALYSIS_MODE_ANALYSIS.equals(mode)) {
+ throw new IllegalStateException("Invalid analysis mode: " + mode);
+ }
+ }
}
*/
package org.sonar.batch.scan;
+import org.apache.commons.lang.StringUtils;
import org.sonar.batch.bootstrap.BootstrapProperties;
-
import org.sonar.batch.bootstrap.AnalysisProperties;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
preview = "true".equals(getPropertyWithFallback(analysisProps, globalProps, CoreProperties.DRY_RUN));
} else {
String mode = getPropertyWithFallback(analysisProps, globalProps, CoreProperties.ANALYSIS_MODE);
+ validate(mode);
preview = CoreProperties.ANALYSIS_MODE_PREVIEW.equals(mode);
quick = CoreProperties.ANALYSIS_MODE_QUICK.equals(mode);
}
return "true".equals(props.get(CoreProperties.DRY_RUN)) || CoreProperties.ANALYSIS_MODE_PREVIEW.equals(mode) ||
CoreProperties.ANALYSIS_MODE_QUICK.equals(mode);
}
+
+ private void validate(String mode) {
+ if (StringUtils.isEmpty(mode)) {
+ return;
+ }
+
+ if (!CoreProperties.ANALYSIS_MODE_PREVIEW.equals(mode) && !CoreProperties.ANALYSIS_MODE_QUICK.equals(mode) &&
+ !CoreProperties.ANALYSIS_MODE_ANALYSIS.equals(mode)) {
+ throw new IllegalStateException("Invalid analysis mode: " + mode);
+ }
+ }
}
@Test
public void regular_analysis_by_default() {
- ProjectAnalysisMode mode = createMode(null);
-
- assertThat(mode.isPreview()).isFalse();
-
- mode = createMode(CoreProperties.ANALYSIS_MODE, "pouet");
-
+ ProjectAnalysisMode mode = createMode(null, null);
assertThat(mode.isPreview()).isFalse();
}
assertThat(mode.isPreview()).isFalse();
}
+ @Test(expected = IllegalStateException.class)
+ public void validate_mode() {
+ createMode(CoreProperties.ANALYSIS_MODE_INCREMENTAL);
+ }
+
@Test
public void support_preview_mode() {
ProjectAnalysisMode mode = createMode(CoreProperties.ANALYSIS_MODE_PREVIEW);