Quote references to the user table in consistency checks (#18072)

Although #17487 ensured that the table was quoted in the join it missed that the
query part of the check also needed to be quoted.

Fix #17485

Signed-off-by: Andrew Thornton <art27@cantab.net>

diff --git a/modules/doctor/dbconsistency.go b/modules/doctor/dbconsistency.go
index e5f0c5678d3093be658feae491c1683c83b9626d..cd34994e1a8323c064b8717a5363d20bf9758f25 100644 (file)
--- a/modules/doctor/dbconsistency.go
+++ b/modules/doctor/dbconsistency.go
@@ -167,13 +167,13 @@ func checkDBConsistency(logger log.Logger, autofix bool) error {
                        "lfs_lock", "repository", "lfs_lock.repo_id=repository.id"),
                // find collaborations without users
                genericOrphanCheck("Collaborations without existing user",
-                       "collaboration", "user", "collaboration.user_id=user.id"),
+                       "collaboration", "user", "collaboration.user_id=`user`.id"),
                // find collaborations without repository
                genericOrphanCheck("Collaborations without existing repository",
                        "collaboration", "repository", "collaboration.repo_id=repository.id"),
                // find access without users
                genericOrphanCheck("Access entries without existing user",
-                       "access", "user", "access.user_id=user.id"),
+                       "access", "user", "access.user_id=`user`.id"),
                // find access without repository
                genericOrphanCheck("Access entries without existing repository",
                        "access", "repository", "access.repo_id=repository.id"),