Fix Quality flaws

diff --git a/server/sonar-server/src/main/java/org/sonar/server/issue/index/IssueIndex.java b/server/sonar-server/src/main/java/org/sonar/server/issue/index/IssueIndex.java
index 24289e2b7b087257418cde9cb789d105b3f0bc1a..3be66691e4e360a747abb5484bea1a14e326bd07 100644 (file)
--- a/server/sonar-server/src/main/java/org/sonar/server/issue/index/IssueIndex.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/issue/index/IssueIndex.java
@@ -245,7 +245,7 @@ public class IssueIndex extends BaseIndex {
     }
   }
 
-  private void configurePagination(SearchOptions options, SearchRequestBuilder esSearch) {
+  private static void configurePagination(SearchOptions options, SearchRequestBuilder esSearch) {
     esSearch.setFrom(options.getOffset()).setSize(options.getLimit());
   }
 

diff --git a/sonar-db/src/main/java/org/sonar/db/version/v60/DropTreesOfSnapshots.java b/sonar-db/src/main/java/org/sonar/db/version/v60/DropTreesOfSnapshots.java
index 07a5ac553ce1d327d41e34a09ecaceedf2ba49c4..c5918a50e0d0ab0e0228af909561b8d10f31de8e 100644 (file)
--- a/sonar-db/src/main/java/org/sonar/db/version/v60/DropTreesOfSnapshots.java
+++ b/sonar-db/src/main/java/org/sonar/db/version/v60/DropTreesOfSnapshots.java
@@ -38,10 +38,10 @@ public class DropTreesOfSnapshots extends BaseDataChange {
     massUpdate.select("select id from snapshots where depth > 0");
     massUpdate.update("delete from snapshots where id=?");
     massUpdate.rowPluralName("snapshots");
-    massUpdate.execute(this::handle);
+    massUpdate.execute(DropTreesOfSnapshots::handle);
   }
 
-  private boolean handle(Select.Row row, SqlStatement update) throws SQLException {
+  private static boolean handle(Select.Row row, SqlStatement update) throws SQLException {
     long id = row.getLong(1);
     update.setLong(1, id);
     return true;

diff --git a/sonar-db/src/main/java/org/sonar/db/version/v60/PopulateAnalysisUuidOnMeasures.java b/sonar-db/src/main/java/org/sonar/db/version/v60/PopulateAnalysisUuidOnMeasures.java
index e81abe6b4b9db67f82268a2979ca1ea79e8736f7..0e87df1e8607f67ae3efdc7bcd68fe0ae14e0676 100644 (file)
--- a/sonar-db/src/main/java/org/sonar/db/version/v60/PopulateAnalysisUuidOnMeasures.java
+++ b/sonar-db/src/main/java/org/sonar/db/version/v60/PopulateAnalysisUuidOnMeasures.java
@@ -42,10 +42,10 @@ public class PopulateAnalysisUuidOnMeasures extends BaseDataChange {
       "where m.analysis_uuid is null");
     massUpdate.update("update project_measures set analysis_uuid=? where snapshot_id=? and analysis_uuid is null");
     massUpdate.rowPluralName("measures");
-    massUpdate.execute(this::handle);
+    massUpdate.execute(PopulateAnalysisUuidOnMeasures::handle);
   }
 
-  private boolean handle(Select.Row row, SqlStatement update) throws SQLException {
+  private static boolean handle(Select.Row row, SqlStatement update) throws SQLException {
     long snapshotId = row.getLong(1);
     String analysisUuid = row.getString(2);