]> source.dussan.org Git - vaadin-framework.git/commitdiff
potential fixes for the tests (#11226)
authorsergey-vaadin <sergey@vaadin.com>
Wed, 10 Oct 2018 12:39:31 +0000 (15:39 +0300)
committerOlli Tietäväinen <ollit@vaadin.com>
Wed, 10 Oct 2018 12:39:31 +0000 (15:39 +0300)
* potential fixes for the tests

uitest/src/main/java/com/vaadin/tests/themes/LegacyComponentThemeChange.java
uitest/src/test/java/com/vaadin/tests/application/CriticalNotificationsTest.java

index 9579888e6d5f01ad873cf71e7f040aa8b63b460b..0a41e327b11914b62da82f744645da8801b51c48 100644 (file)
@@ -28,6 +28,7 @@ import com.vaadin.ui.Button.ClickListener;
 import com.vaadin.ui.ComboBox;
 import com.vaadin.ui.Embedded;
 import com.vaadin.ui.HorizontalLayout;
+import com.vaadin.ui.Label;
 import com.vaadin.ui.MenuBar;
 import com.vaadin.ui.MenuBar.MenuItem;
 import com.vaadin.ui.Table;
@@ -39,6 +40,7 @@ public class LegacyComponentThemeChange extends AbstractTestUIWithLog {
     @Override
     protected void setup(VaadinRequest request) {
         VerticalLayout vl = new VerticalLayout();
+        vl.setSpacing(true);
         vl.setCaption("Change theme by clicking a button");
         HorizontalLayout hl = new HorizontalLayout();
         for (final String theme : new String[] { "reindeer", "runo" }) {
@@ -67,6 +69,7 @@ public class LegacyComponentThemeChange extends AbstractTestUIWithLog {
         sub.addItem("selectedtheme", varyingIcon, null);
 
         vl.addComponent(bar);
+        vl.addComponent(new Label("gap"));
 
         ComboBox cb = new ComboBox("ComboBox");
         cb.addItem("No icon");
index aa590f272822d20cde9c876d28c1dde8ca747955..0f43a4e189335932912c368ee42ff0b4d0abbe07 100644 (file)
@@ -64,7 +64,7 @@ public class CriticalNotificationsTest extends MultiBrowserThemeTest {
         testBench().disableWaitForVaadin();
 
         // Give the notification some time to animate
-        sleep(1000);
+        sleep(2000);
         compareScreen($(NotificationElement.class).first(),
                 "systemnotification");
     }