Fix #12336. Ensure oldIE really does .empty() selects.

diff --git a/src/manipulation.js b/src/manipulation.js
index 5fec948cb41f8bc34cd94e3a0cfd00eaa4b50e37..e8c0fe46f9237e5a7a18af4b7d39c015a7ab8d49 100644 (file)
--- a/src/manipulation.js
+++ b/src/manipulation.js
@@ -192,6 +192,12 @@ jQuery.fn.extend({
                        while ( elem.firstChild ) {
                                elem.removeChild( elem.firstChild );
                        }
+
+                       // If this is a select, ensure that it displays empty (#12336)
+                       // Support: IE<9
+                       if ( elem.options && jQuery.nodeName( elem, "select" ) ) {
+                               elem.options.length = 0;
+                       }
                }
 
                return this;

diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js
index 86b26e040c2d54360df69cb156e017776b838ff3..d208b3b7a9f4fa8c042bf2e7a6fbdcdfe76265fa 100644 (file)
--- a/test/unit/manipulation.js
+++ b/test/unit/manipulation.js
@@ -1829,7 +1829,7 @@ test( "detach() event cleaning ", 1, function() {
 
 test("empty()", function() {
 
-       expect( 3 );
+       expect( 6 );
 
        equal( jQuery("#ap").children().empty().text().length, 0, "Check text is removed" );
        equal( jQuery("#ap").children().length, 4, "Check elements are not removed" );
@@ -1838,7 +1838,13 @@ test("empty()", function() {
        var j = jQuery("#nonnodes").contents();
        j.empty();
        equal( j.html(), "", "Check node,textnode,comment empty works" );
-});
+
+       // Ensure oldIE empties selects (#12336)
+       notEqual( $("#select1").find("option").length, 0, "Have some initial options" );
+       $("#select1").empty();
+       equal( $("#select1").find("option").length, 0, "No more option elements found" );
+       equal( $("#select1")[0].options.length, 0, "options.length cleared as well" );
+       });
 
 test( "jQuery.cleanData", function() {