]> source.dussan.org Git - redmine.git/commitdiff
Merged r15952 and r15953 (#23922).
authorJean-Philippe Lang <jp_lang@yahoo.fr>
Sat, 3 Dec 2016 08:38:40 +0000 (08:38 +0000)
committerJean-Philippe Lang <jp_lang@yahoo.fr>
Sat, 3 Dec 2016 08:38:40 +0000 (08:38 +0000)
git-svn-id: http://svn.redmine.org/redmine/branches/3.3-stable@16043 e93f8b46-1217-0410-a6f0-8f06a7374b81

app/controllers/context_menus_controller.rb
app/controllers/timelog_controller.rb

index dc8e726093bc2bfa5a17c94c4a7bdd83f952960d..903f13f005d2f53a96084242bb1c360415057f37 100644 (file)
@@ -59,7 +59,10 @@ class ContextMenusController < ApplicationController
   end
 
   def time_entries
-    @time_entries = TimeEntry.where(:id => params[:ids]).preload(:project).to_a
+    @time_entries = TimeEntry.where(:id => params[:ids]).
+      preload(:project => :time_entry_activities).
+      preload(:user).to_a
+
     (render_404; return) unless @time_entries.present?
     if (@time_entries.size == 1)
       @time_entry = @time_entries.first
@@ -67,7 +70,7 @@ class ContextMenusController < ApplicationController
 
     @projects = @time_entries.collect(&:project).compact.uniq
     @project = @projects.first if @projects.size == 1
-    @activities = TimeEntryActivity.shared.active
+    @activities = @projects.map(&:activities).reduce(:&)
 
     edit_allowed = @time_entries.all? {|t| t.editable_by?(User.current)}
     @can = {:edit => edit_allowed, :delete => edit_allowed}
index 7e4d6b71dd0047ed755030314c7818d2ed0e0a8b..acb106d3bd3dd45743c89185f67b5bbf6f554c07 100644 (file)
@@ -170,7 +170,7 @@ class TimelogController < ApplicationController
   end
 
   def bulk_edit
-    @available_activities = TimeEntryActivity.shared.active
+    @available_activities = @projects.map(&:activities).reduce(:&)
     @custom_fields = TimeEntry.first.available_custom_fields
   end
 
@@ -236,7 +236,10 @@ private
   end
 
   def find_time_entries
-    @time_entries = TimeEntry.where(:id => params[:id] || params[:ids]).to_a
+    @time_entries = TimeEntry.where(:id => params[:id] || params[:ids]).
+      preload(:project => :time_entry_activities).
+      preload(:user).to_a
+
     raise ActiveRecord::RecordNotFound if @time_entries.empty?
     raise Unauthorized unless @time_entries.all? {|t| t.editable_by?(User.current)}
     @projects = @time_entries.collect(&:project).compact.uniq