list.php files are only invoked via ViewController and APIController

Both of them actually check that the user is logged in before
and also the list.php files themselves would break with
getUserSession()->getUser()->getUID() which they contain.

Signed-off-by: Joas Schilling <coding@schilljs.com>

diff --git a/apps/files/list.php b/apps/files/list.php
index 9d3e1a33b0fb926494fe6c5496a145c7d7e3e8a6..09dc217139c6a56c48769b8725012a6858ab52f8 100644 (file)
--- a/apps/files/list.php
+++ b/apps/files/list.php
@@ -29,7 +29,7 @@ $userSession = \OC::$server->getUserSession();
 // TODO: move this to the generated config.js
 /** @var IManager $shareManager */
 $shareManager = \OC::$server->get(IManager::class);
-$publicUploadEnabled = $shareManager->shareApiLinkAllowPublicUpload() ? 'yes' : 'no';;
+$publicUploadEnabled = $shareManager->shareApiLinkAllowPublicUpload() ? 'yes' : 'no';
 
 $showgridview = $config->getUserValue($userSession->getUser()->getUID(), 'files', 'show_grid', false);
 

diff --git a/apps/files/recentlist.php b/apps/files/recentlist.php
index 2d250e1fc37f0becf683cb363e61999d9c106eaf..874ecca957cb041d27da9fb619c5e7b6dc6477ee 100644 (file)
--- a/apps/files/recentlist.php
+++ b/apps/files/recentlist.php
@@ -23,8 +23,7 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>.
  *
  */
-// Check if we are a user
-OC_Util::checkLoggedIn();
+
 $config = \OC::$server->getConfig();
 $userSession = \OC::$server->getUserSession();
 

diff --git a/apps/files_external/list.php b/apps/files_external/list.php
index f230057f3d2524c1db07f97ac7ced9ebafde0e61..f38e9da1bc3ce7933e795eb01daf102b95b5bec0 100644 (file)
--- a/apps/files_external/list.php
+++ b/apps/files_external/list.php
@@ -23,8 +23,7 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>
  *
  */
-// Check if we are a user
-OC_Util::checkLoggedIn();
+
 $config = \OC::$server->getConfig();
 $userSession = \OC::$server->getUserSession();
 

diff --git a/apps/files_sharing/list.php b/apps/files_sharing/list.php
index f9f6ddd3bc52570c0b14cc2c532bc9774fec0ddf..edcfdc180a6466907fb02871800443797d41c4e4 100644 (file)
--- a/apps/files_sharing/list.php
+++ b/apps/files_sharing/list.php
@@ -28,8 +28,6 @@ use OCA\Files\Event\LoadSidebar;
 use OCA\Viewer\Event\LoadViewer;
 use OCP\EventDispatcher\GenericEvent;
 
-// Check if we are a user
-OC_Util::checkLoggedIn();
 $config = \OC::$server->getConfig();
 $userSession = \OC::$server->getUserSession();
 $legacyEventDispatcher = \OC::$server->getEventDispatcher();

diff --git a/apps/files_trashbin/list.php b/apps/files_trashbin/list.php
index 3a4e6d7d1e20ea636833807397a7e4ce6b764490..117d3b4ddfeb72e2cda9df43bf32e06da074d1f1 100644 (file)
--- a/apps/files_trashbin/list.php
+++ b/apps/files_trashbin/list.php
@@ -24,8 +24,6 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>
  *
  */
-// Check if we are a user
-OC_Util::checkLoggedIn();
 
 $config = \OC::$server->getConfig();
 $userSession = \OC::$server->getUserSession();

diff --git a/apps/systemtags/list.php b/apps/systemtags/list.php
index d7ba2c9eed9ace6c6aff476106c1f1483cdb6fc0..b5bbf223f29ac6c31c5d41ff236161f17e81ec27 100644 (file)
--- a/apps/systemtags/list.php
+++ b/apps/systemtags/list.php
@@ -20,23 +20,6 @@
  * along with this program. If not, see <http://www.gnu.org/licenses/>
  *
  */
-// WARNING: this should be moved to proper AppFramework handling
-// Check if we are a user
-if (!\OC::$server->getUserSession()->isLoggedIn()) {
-       header('Location: ' . \OC::$server->getURLGenerator()->linkToRoute(
-                       'core.login.showLoginForm',
-                       [
-                               'redirect_url' => \OC::$server->getRequest()->getRequestUri(),
-                       ]
-               )
-       );
-       exit();
-}
-// Redirect to 2FA challenge selection if 2FA challenge was not solved yet
-if (\OC::$server->getTwoFactorAuthManager()->needsSecondFactor(\OC::$server->getUserSession()->getUser())) {
-       header('Location: ' . \OC::$server->getURLGenerator()->linkToRoute('core.TwoFactorChallenge.selectChallenge'));
-       exit();
-}
 
 $tmpl = new OCP\Template('systemtags', 'list', '');
 $tmpl->printPage();