]> source.dussan.org Git - sonarqube.git/commitdiff
SONAR-20184 Don't return group and token count in API v2 users responses.
authorWojtek Wajerowicz <115081248+wojciech-wajerowicz-sonarsource@users.noreply.github.com>
Tue, 22 Aug 2023 14:37:33 +0000 (16:37 +0200)
committersonartech <sonartech@sonarsource.com>
Tue, 22 Aug 2023 20:03:05 +0000 (20:03 +0000)
server/sonar-webserver-webapi-v2/src/main/java/org/sonar/server/v2/api/user/converter/UsersSearchRestResponseGenerator.java
server/sonar-webserver-webapi-v2/src/main/java/org/sonar/server/v2/api/user/model/RestUserForAdmins.java
server/sonar-webserver-webapi-v2/src/test/java/org/sonar/server/v2/api/user/controller/DefaultUserControllerTest.java
server/sonar-webserver-webapi-v2/src/test/java/org/sonar/server/v2/api/user/converter/UsersSearchRestResponseGeneratorTest.java

index f92c3e3784dd4a2712bd16e3b5ec05c0bf2f55b5..ef3c07b5702aefaa4001cc51750e6bb8ac1c531a 100644 (file)
@@ -76,8 +76,6 @@ public class UsersSearchRestResponseGenerator implements UsersSearchResponseGene
       Boolean managed = userSearchResult.managed();
       String sqLastConnectionDate = toDateTime(userDto.getLastConnectionDate());
       String slLastConnectionDate = toDateTime(userDto.getLastSonarlintConnectionDate());
-      int groupSize = userSearchResult.groups().size();
-      int tokensCount = userSearchResult.tokensCount();
       List<String> scmAccounts = userSearchResult.userDto().getSortedScmAccounts();
       return new RestUserForAdmins(
         login,
@@ -92,8 +90,6 @@ public class UsersSearchRestResponseGenerator implements UsersSearchResponseGene
         avatar,
         sqLastConnectionDate,
         slLastConnectionDate,
-        groupSize,
-        tokensCount,
         scmAccounts);
     }
     return new RestUserForLoggedInUsers(login, login, name, email, active, local, externalIdentityProvider, avatar);
index cb559458da1c154b979e1980d26d87d0fab028cb..5de5cc9bdbc941864e13bdd3231974074ec6fba3 100644 (file)
@@ -45,10 +45,6 @@ public record RestUserForAdmins(
   @Nullable
   String sonarLintLastConnectionDate,
   @Nullable
-  Integer groupsCount,
-  @Nullable
-  Integer tokensCount,
-  @Nullable
   List<String> scmAccounts
 ) implements RestUser {
 }
index 290f87e10f92afcbc3546579ff8ccc88a4bb1b2a..ed6a8bd2b55547abe800a2be951066701e48c569 100644 (file)
@@ -213,8 +213,6 @@ public class DefaultUserControllerTest {
       userSearchResult.avatar().orElse(""),
       formatDateTime(userSearchResult.userDto().getLastConnectionDate()),
       formatDateTime(userSearchResult.userDto().getLastSonarlintConnectionDate()),
-      userSearchResult.groups().size(),
-      userSearchResult.tokensCount(),
       userSearchResult.userDto().getSortedScmAccounts());
   }
 
index 665e80a276121ea3b27af414c49b04dc61e9fe3c..d1f40524fd946c1d5a20d6ff92ebd9ca500608fd 100644 (file)
@@ -96,8 +96,6 @@ public class UsersSearchRestResponseGeneratorTest {
       userSearchResult.avatar().orElse(null),
       toDateTime(userDto.getLastConnectionDate()),
       toDateTime(userDto.getLastSonarlintConnectionDate()),
-      userSearchResult.groups().size(),
-      userSearchResult.tokensCount(),
       userSearchResult.userDto().getSortedScmAccounts()
     );
   }
@@ -178,8 +176,6 @@ public class UsersSearchRestResponseGeneratorTest {
 
     when(userSearchResult.userDto()).thenReturn(user1);
     when(userSearchResult.managed()).thenReturn(booleanFlagsValue);
-    when(userSearchResult.tokensCount()).thenReturn(i);
-    when(userSearchResult.groups().size()).thenReturn(i * 100);
     return userSearchResult;
   }