]> source.dussan.org Git - gitea.git/commitdiff
Remove label color from global issue filters (#22660)
authorFrancesco Siddi <francesco.siddi@gmail.com>
Tue, 31 Jan 2023 12:58:34 +0000 (13:58 +0100)
committerGitHub <noreply@github.com>
Tue, 31 Jan 2023 12:58:34 +0000 (20:58 +0800)
The use of ui colors (red, green, etc) should be limited to actionable
or dismissable entries. Before this commit, a green/red label was used
to display issues count on each repository. This did not add any
meaningful information to the list.

Removing the label reduces ambiguity and makes the list easier to scan
visually.

![label_compare](https://user-images.githubusercontent.com/451841/215360696-a881b765-207d-4ffa-8bec-398f8e5dab1e.jpg)

---------

Co-authored-by: delvh <dev.lh@web.de>
templates/user/dashboard/issues.tmpl

index 1a0271d8f0cc00263cca1e1e6bb0d055d541a069..4ff6772a72935c27846619e63bf10ac81f5de04e 100644 (file)
@@ -30,7 +30,7 @@
                                        <div class="ui divider"></div>
                                        <a class="{{if not $.RepoIDs}}ui basic primary button{{end}} repo name item" href="{{$.Link}}?type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&q={{$.Keyword}}">
                                                <span class="text truncate">All</span>
-                                               <div class="ui {{if $.IsShowClosed}}red{{else}}green{{end}} label">{{CountFmt .TotalIssueCount}}</div>
+                                               <span class="ui">{{CountFmt .TotalIssueCount}}</span>
                                        </a>
                                        {{range .Repos}}
                                                {{with $Repo := .}}
@@ -49,7 +49,7 @@
                                                                        {{- end -}}
                                                                        ]&sort={{$.SortType}}&state={{$.State}}&q={{$.Keyword}}" title="{{.FullName}}">
                                                                <span class="text truncate">{{$Repo.FullName}}</span>
-                                                               <div class="ui {{if $.IsShowClosed}}red{{else}}green{{end}} label">{{CountFmt (index $.Counts $Repo.ID)}}</div>
+                                                               <span class="ui">{{CountFmt (index $.Counts $Repo.ID)}}</span>
                                                        </a>
                                                {{end}}
                                        {{end}}