]> source.dussan.org Git - gitea.git/commitdiff
Don't install playwright twice (#29302)
authorsilverwind <me@silverwind.io>
Thu, 22 Feb 2024 03:19:13 +0000 (04:19 +0100)
committerGitHub <noreply@github.com>
Thu, 22 Feb 2024 03:19:13 +0000 (03:19 +0000)
1. `playwright/test` is already installed as part of `deps-frontend` on
CI which runs before, so it's better to not install it again (on a
potentially different version), and just use the version from
package.json and add the `deps-frontend` dependency.
2. `PLAYWRIGHT_DIR` is a undefined variable, so I removed it

```bash
$ git show c8ded77680db7344c8dc1ccee76bce0b4e02e103 | grep PLAYWRIGHT_DIR
+playwright: $(PLAYWRIGHT_DIR)
```

Makefile

index 925fdcb946b6904fe51c9c5b82c3d4c1bced6160..7fa819380073b4805cf4c53bac98e143cd58e0cd 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -602,8 +602,7 @@ test-mssql\#%: integrations.mssql.test generate-ini-mssql
 test-mssql-migration: migrations.mssql.test migrations.individual.mssql.test
 
 .PHONY: playwright
-playwright: $(PLAYWRIGHT_DIR)
-       npm install --no-save @playwright/test
+playwright: deps-frontend
        npx playwright install $(PLAYWRIGHT_FLAGS)
 
 .PHONY: test-e2e%