Code cleanup: RuboCop: Style/DefWithParentheses

git-svn-id: http://svn.redmine.org/redmine/trunk@18290 e93f8b46-1217-0410-a6f0-8f06a7374b81

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index a2dedd51b8123f1e73572aef360172d6752204b5..170f02ea45800737513d6f1cf847606d77bdd8a9 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1444,14 +1444,6 @@ Style/CommentedKeyword:
 Style/ConditionalAssignment:
   Enabled: false
 
-# Offense count: 3
-# Cop supports --auto-correct.
-Style/DefWithParentheses:
-  Exclude:
-    - 'app/helpers/sort_helper.rb'
-    - 'lib/redmine/scm/adapters/cvs_adapter.rb'
-    - 'lib/redmine/unified_diff.rb'
-
 # Offense count: 626
 Style/Documentation:
   Enabled: false

diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index f96a3a7839d69b131fed90890e0200f436c45155..5c2957c4fd4583aa508a60b94c3bcbc55b101170 100644 (file)
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -551,7 +551,7 @@ module IssuesHelper
   end
 
   # Issue history tabs
-  def issue_history_tabs()
+  def issue_history_tabs
     tabs = []
     if @journals.present?
       journals_without_notes = @journals.select{|value| value.notes.blank?}

diff --git a/app/helpers/sort_helper.rb b/app/helpers/sort_helper.rb
index ab006599373e62a64694a4de3adcba80693a384c..5350774b2f7a866ab7b54bf8cc3d7bff0182b135 100644 (file)
--- a/app/helpers/sort_helper.rb
+++ b/app/helpers/sort_helper.rb
@@ -96,7 +96,7 @@ module SortHelper
   # Returns an SQL sort clause corresponding to the current sort state.
   # Use this to sort the controller's table items collection.
   #
-  def sort_clause()
+  def sort_clause
     @sort_criteria.sort_clause(@sortable_columns)
   end
 

diff --git a/lib/redmine/scm/adapters/cvs_adapter.rb b/lib/redmine/scm/adapters/cvs_adapter.rb
index f0f4d54dfe5d2e246fa72646405404a0a42c4ce0..ff642054e69b5a92b74fcb16743ed32b60908c3a 100644 (file)
--- a/lib/redmine/scm/adapters/cvs_adapter.rb
+++ b/lib/redmine/scm/adapters/cvs_adapter.rb
@@ -445,7 +445,7 @@ module Redmine
         end
 
         # Interpretiert die cvs revisionsnummern wie z.b. 1.14 oder 1.3.0.15
-        def parseRevision()
+        def parseRevision
           pieces = @complete_rev.split(".")
           @revision = pieces.last.to_i
           baseSize = 1

diff --git a/lib/redmine/unified_diff.rb b/lib/redmine/unified_diff.rb
index 697d7c52532f6089f28edf9f91c435a48ae35be0..5660fa91d05040a4d69c1a64b1ef3e573bfa23e8 100644 (file)
--- a/lib/redmine/unified_diff.rb
+++ b/lib/redmine/unified_diff.rb
@@ -227,7 +227,7 @@ module Redmine
     attr_accessor :type_diff_left
     attr_accessor :offsets
 
-    def initialize()
+    def initialize
       self.nb_line_left = ''
       self.nb_line_right = ''
       self.line_left = ''