when we receive intentional empty whats new info, do not try to show it

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

diff --git a/lib/private/Updater/ChangesCheck.php b/lib/private/Updater/ChangesCheck.php
index 095cf396e89e3f4ecfc73ccf443aef1ac31f82e6..575a9ceadaf34d4c86e25c686ac8aed2822a518e 100644 (file)
--- a/lib/private/Updater/ChangesCheck.php
+++ b/lib/private/Updater/ChangesCheck.php
@@ -53,7 +53,11 @@ class ChangesCheck {
        public function getChangesForVersion(string $version): array {
                $version = $this->normalizeVersion($version);
                $changesInfo = $this->mapper->getChanges($version);
-               return json_decode($changesInfo->getData(), true);
+               $changesData = json_decode($changesInfo->getData(), true);
+               if(empty($changesData)) {
+                       throw new DoesNotExistException();
+               }
+               return $changesData;
        }
 
        /**

diff --git a/tests/lib/Updater/ChangesCheckTest.php b/tests/lib/Updater/ChangesCheckTest.php
index fe25e8cebaff566b48331c2481f2ac54ed420d81..2b1954ee48f2312b16987f04c8f09b5b1c24827d 100644 (file)
--- a/tests/lib/Updater/ChangesCheckTest.php
+++ b/tests/lib/Updater/ChangesCheckTest.php
@@ -279,6 +279,10 @@ class ChangesCheckTest extends TestCase {
                                        ],
                                ]
                        ],
+                       [ # 4 - empty
+                               '',
+                               []
+                       ],
                ];
        }