if request.post?
Setting.send "plugin_#{@plugin.id}=", params[:settings]
flash[:notice] = l(:notice_successful_update)
- redirect_to plugin_settings_path(@plugin.id)
+ redirect_to plugin_settings_path(@plugin)
else
@partial = @plugin.settings[:partial]
@settings = Setting.send "plugin_#{@plugin.id}"
<% if @plugins.any? %>
<table class="list plugins">
<% @plugins.each do |plugin| %>
- <tr class="<%= cycle('odd', 'even') %>">
+ <tr id="plugin-<%= plugin.id %>" class="<%= cycle('odd', 'even') %>">
<td><span class="name"><%=h plugin.name %></span>
<%= content_tag('span', h(plugin.description), :class => 'description') unless plugin.description.blank? %>
<%= content_tag('span', link_to(h(plugin.url), plugin.url), :class => 'url') unless plugin.url.blank? %>
</td>
<td class="author"><%= plugin.author_url.blank? ? h(plugin.author) : link_to(h(plugin.author), plugin.author_url) %></td>
<td class="version"><%=h plugin.version %></td>
- <td class="configure"><%= link_to(l(:button_configure), :controller => 'settings', :action => 'plugin', :id => plugin.id) if plugin.configurable? %></td>
+ <td class="configure"><%= link_to(l(:button_configure), plugin_settings_path(plugin)) if plugin.configurable? %></td>
</tr>
<% end %>
</table>
def test_index
get :index
- assert_no_tag :tag => 'div',
- :attributes => { :class => /nodata/ }
+ assert_select 'div.nodata', 0
end
def test_index_with_no_configuration_data
delete_configuration_data
get :index
- assert_tag :tag => 'div',
- :attributes => { :class => /nodata/ }
+ assert_select 'div.nodata'
end
def test_projects
assert_response :success
assert_template 'plugins'
- assert_tag :td, :child => { :tag => 'span', :content => 'Foo plugin' }
- assert_tag :td, :child => { :tag => 'span', :content => 'Bar' }
+ assert_select 'tr#plugin-foo' do
+ assert_select 'td span.name', :text => 'Foo plugin'
+ assert_select 'td.configure a[href=/settings/plugin/foo]'
+ end
+ assert_select 'tr#plugin-bar' do
+ assert_select 'td span.name', :text => 'Bar'
+ assert_select 'td.configure a', 0
+ end
end
def test_info
get :index
assert_response :success
- assert_tag :a, :attributes => { :href => '/foo/bar' },
- :content => 'Test'
+ assert_select 'div#admin-menu a[href=/foo/bar]', :text => 'Test'
Redmine::MenuManager.map :admin_menu do |menu|
menu.delete :test_admin_menu_plugin_extension